Animes-Online-Cloud-PT] Fix Nenhum Episodio Encontrado#622
Open
Bashousen wants to merge 1 commit into
Open
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideImplements proper episode parsing for AnimesOnlineCloud by defining episode list selectors and mapping HTML episode cards to SEpisode objects, and bumps the extension overrideVersionCode to reflect the fix. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
episodeFromElement, usingselectFirst(... )!!will crash if the markup changes; consider handling a null anchor more defensively and either skipping the episode or logging instead of throwing. - The episode name parsing relies on
ownText().substringAfter(" - "), which assumes a fixed title format; it may be more robust to trim and validate the split parts or fall back to the full text when the separator is missing.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `episodeFromElement`, using `selectFirst(... )!!` will crash if the markup changes; consider handling a null anchor more defensively and either skipping the episode or logging instead of throwing.
- The episode name parsing relies on `ownText().substringAfter(" - ")`, which assumes a fixed title format; it may be more robust to trim and validate the split parts or fall back to the full text when the separator is missing.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
CLoses #577
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extensionAdd a 👍 reaction to pull requests you find important.
Summary by Sourcery
Fix episode listing for the AnimesOnlineCloud PT extension and bump its override version code.
Bug Fixes:
Build: