TopAnimes [PT]: Change domain from Q1N to TopAnimes#641
Open
WebDitto wants to merge 1 commit into
Open
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRenames the Portuguese Q1N extension to TopAnimes, updating its Gradle metadata (name, class, URL, version code) and removing the old Kotlin implementation file, implying the source class was renamed/moved elsewhere. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- You changed
extName/extClassand removedQ1N.ktbut there is no correspondingTopAnimes.ktimplementation in this diff; confirm the new class exists and that the extensionidand package path remain stable to preserve migrations. - Since the base URL changed from
q1n.nettotopanimes.net, double-check that the site structure and paths are still compatible with the existing scraping logic; a pure URL swap may not be sufficient if the new domain differs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You changed `extName`/`extClass` and removed `Q1N.kt` but there is no corresponding `TopAnimes.kt` implementation in this diff; confirm the new class exists and that the extension `id` and package path remain stable to preserve migrations.
- Since the base URL changed from `q1n.net` to `topanimes.net`, double-check that the site structure and paths are still compatible with the existing scraping logic; a pure URL swap may not be sufficient if the new domain differs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extensionAdd a 👍 reaction to pull requests you find important.
Summary by Sourcery
Rename the Portuguese AnimesGratis extension from Q1N to TopAnimes and point it to the new domain.
Enhancements: