Skip to content

AniDB [EN]: Add Studio Filter#658

Merged
Alpha-782 merged 2 commits into
yuzono:masterfrom
Alpha-782:studios-anidb
Jul 15, 2026
Merged

AniDB [EN]: Add Studio Filter#658
Alpha-782 merged 2 commits into
yuzono:masterfrom
Alpha-782:studios-anidb

Conversation

@Alpha-782

@Alpha-782 Alpha-782 commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension
  • This PR is AI-assisted, I have reviewed the changes manually and confirmed they are not slop
  • Have made sure all the icons are in png format

Add a 👍 reaction to pull requests you find important.

Summary by Sourcery

Add a studio-based filter to the AniDB extension and update its version.

New Features:

  • Allow filtering AniDB browse results by production studio via a new Studio filter option.

Enhancements:

  • Route browse requests to dedicated studio listing pages when a specific studio is selected.
  • Increment the AniDB extension version code to reflect the new filtering capability.

@sourcery-ai

sourcery-ai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Adds a new Studio filter to the AniDB extension, wiring it into the browse request flow and bumping the extension version code.

Flow diagram for AniDB browse request with Studio filter

flowchart TD
    A[Start browse] --> B{demographicId != null?}
    B -- Yes --> C[Build /demographics/demographicId URL]
    C --> H[GET demographics URL]
    B -- No --> D{studioId != null?}
    D -- Yes --> E[Build /studios/studioId URL]
    E --> I[GET studios URL]
    D -- No --> F[Build /browse URL]
    F --> G[GET browse URL]
Loading

File-Level Changes

Change Details Files
Introduce a Studio filter option for AniDB browsing.
  • Add Filters.StudioFilter as a UriPartFilter with a predefined list of studio name/id mappings and a default "All" option
  • Expose the Studio filter in the extension’s filter list alongside existing demographic, genre, theme, and sort filters
src/en/anidb/src/eu/kanade/tachiyomi/animeextension/en/anidb/Filters.kt
Wire the Studio filter into AniDB browse URL construction.
  • Track the selected studio ID during filter processing when no text query is present
  • When a studio is selected, construct browse requests against the /studios/{id} endpoint with page query parameter
  • Keep existing behavior for other filters (demographic, theme, sort) when studio is not selected
src/en/anidb/src/eu/kanade/tachiyomi/animeextension/en/anidb/AniDB.kt
Bump AniDB extension version for the new filter feature.
  • Increment extVersionCode from 2 to 3 to signal the new functionality
src/en/anidb/build.gradle

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The StudioFilter definition hardcodes a very large list of pairs inline; consider moving this data into a separate constant or data file (or at least a dedicated val studios = arrayOf(...)) to keep Filters.kt more readable and maintainable.
  • If the studio list is meant to be user-browsable, you may want to ensure it is consistently sorted and de-duplicated and add a brief comment on how/where the IDs were sourced, so future updates can follow the same convention.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `StudioFilter` definition hardcodes a very large list of pairs inline; consider moving this data into a separate constant or data file (or at least a dedicated `val studios = arrayOf(...)`) to keep `Filters.kt` more readable and maintainable.
- If the studio list is meant to be user-browsable, you may want to ensure it is consistently sorted and de-duplicated and add a brief comment on how/where the IDs were sourced, so future updates can follow the same convention.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Alpha-782
Alpha-782 merged commit f7f287a into yuzono:master Jul 15, 2026
4 checks passed
@Alpha-782
Alpha-782 deleted the studios-anidb branch July 15, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant