Skip to content

support module interface reading file paths #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support module interface reading file paths #112

wants to merge 1 commit into from

Conversation

CADBOT
Copy link

@CADBOT CADBOT commented Jun 15, 2018

Added fix for issue 110

@CADBOT
Copy link
Author

CADBOT commented Jun 15, 2018

If you like the change I can add tests too

@CADBOT CADBOT mentioned this pull request Jun 15, 2018
Open
@prantlf
Copy link

prantlf commented May 18, 2019

This change breaks the parse method. If a string like "./x" is passed to it, the method should fail with an invalid JSON input. Not trying to be smart and trying to handle the input string as a file path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CADBOT @prantlf