I started working on context function pgettext #96
+105
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working on zaach#94. Extracting works. But joining joins incorrectly. If I parse both files they are joined correctly.
There was a problem hiding this comment.
It wont work well, since it makes impossible to use plurals with context and all other future combinations.
Though, I must say that to make it work original section must be refactored too.
Author
There was a problem hiding this comment.
Another option is for function getTranslatable to return object instead of array. And in object you would have context, singular, plural, domain keys values would be the same objects that are in array. That way you can have context with plurals and other combinations. IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed context support so I added it. Since library supports everything else.
My addition is a little hackish IMHO I added third item in list which is returned from getTranslatable. So normal gettext returns item, plural returns 2 item array, context 3 item. First item is key second is context.
Any suggestions for improvement are welcome. I'm not at home in Javascript I think I changed all the necessary code. I'll add some handlebar tests.
Working on #94.
Extracting works. I also added tests. I updated same tests that adding ngettext changed.
Joining works if I parse both files (they are correctly deduplicated). But If I join with existing messages.pot like join test is doing they are joined incorrectly.
In addition to correctly joined msgid there is another from the second file