Yak shaving#34
Open
FoxLisk wants to merge 7 commits into
Open
Conversation
the older version was failing to initialize some value and crashing probably a windows thing
i dont know why `cargo test` runs benchmarks. I feel like it didn't used to? but it does for me and that's very annoying You can run them with `cargo bench --features run_benches`
rustc_serialize is deprecated. modernize! modernize! MODERNIZE!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm thinking about doing some more hacking on this but getting it to build and run and everything ran into some issues. This cleans up some lints, updates some dependencies, and swaps in
serdefor the deprecatedrustc-serialize. there should be no behaviour change.