Skip to content

fix(hdc): convert duration_ms to swipeVelocityPps_ for HarmonyOS swipe #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
growvv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(hdc): convert duration_ms to swipeVelocityPps_ for HarmonyOS swipe #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions phone_agent/hdc/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,14 +184,15 @@ def swipe(

hdc_prefix = _get_hdc_prefix(device_id)

# Calculate duration_ms if not provided, then convert to swipeVelocityPps_
import math
distance = math.sqrt((start_x - end_x) ** 2 + (start_y - end_y) ** 2)
if duration_ms is None:
# Calculate duration based on distance
dist_sq = (start_x - end_x) ** 2 + (start_y - end_y) ** 2
duration_ms = int(dist_sq / 1000)
duration_ms = max(500, min(duration_ms, 1000)) # Clamp between 500-1000ms
duration_ms = int(distance ** 2 / 1000)
duration_ms = max(500, min(duration_ms, 1000)) # Clamp between 500-1000ms
swipeVelocityPps_ = int((distance / duration_ms) * 1000)
swipeVelocityPps_ = max(500, min(swipeVelocityPps_, 40000)) # Clamp between 500-40000 pps

# HarmonyOS uses uitest uiInput swipe
# Format: swipe startX startY endX endY duration
_run_hdc_command(
hdc_prefix
+ [
Expand All @@ -203,7 +204,7 @@ def swipe(
str(start_y),
str(end_x),
str(end_y),
str(duration_ms),
str(swipeVelocityPps_),
],
capture_output=True,
)
Expand Down
Loading