Skip to content

Conversation

@guuzaa
Copy link
Contributor

@guuzaa guuzaa commented Jan 10, 2026

Description

Added missing dependency sniffio.

Fixes #53

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds sniffio as an explicit dependency to fix issue #53. The library is imported and used in src/zai/core/_utils/_utils.py for detecting the current async library, but was previously only available as a transitive dependency through httpxanyiosniffio.

Changes:

  • Added sniffio = "^1.3.1" to the main dependencies in pyproject.toml
  • Updated poetry.lock with new content hash reflecting the dependency change

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Added sniffio as an explicit dependency to ensure it's available when imported directly
poetry.lock Updated lock file with new content hash; Poetry version also updated from 2.1.4 to 2.2.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@guuzaa
Copy link
Contributor Author

guuzaa commented Jan 12, 2026

You should re-run poetry lock to update poetry.lock.
In my opinion, ^ is a better choice than >=. ^ means versions that won't break backward compatibility, while >= means any version equal to or higher than 1.3.1 including breaking changes.

@tomsun28
Copy link
Member

You should re-run poetry lock to update poetry.lock. In my opinion, ^ is a better choice than >=. ^ means versions that won't break backward compatibility, while >= means any version equal to or higher than 1.3.1 including breaking changes.

hi, suggest keeping it consistent with others. and avoid cases where multiple version ranges have no intersection.

@tomsun28 tomsun28 merged commit 145a6b1 into zai-org:main Jan 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ModuleNotFoundError: No module named 'sniffio'

2 participants