Helloshiv01 patch 1 #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to the code
The use of isspace() function from ctype.h instead of checking for space and newline characters separately. The use of a while loop instead of a do-while loop when scanning identifier names to avoid writing to the array out-of-bounds if the identifier name exceeds the maximum length. The use of isdigit() function from ctype.h instead of checking if a character is a digit by comparing it to characters '0' to '9'. The use of a switch statement to handle the different cases of characters that can be encountered in the input. The lookahead() function has been simplified by returning the value returned by the lex() function directly.
zakirullin
reviewed
Mar 16, 2023
LICENSE.md
Outdated
There was a problem hiding this comment.
Removed LICENSE.md ruins the build, accidental removal?
The rest is awesome! 👍
|
yes it was accidental i am really sorry |
It's okay, I haven't merged it yet. Can you please revert it back and I'll accept your PR as whole? |
added license file which was deleted accidently.
|
done. |
|
I run the build ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error handling and error recovery