MID-2411: Bump Generate Ingress API Version #62
Conversation
| span.setTag("response_payload", response.toString) | ||
| response | ||
| } | ||
| withoutSizeLimit { |
There was a problem hiding this comment.
This was added due to an issue I hit when we were processing very large request payloads. It's not currently happening after several rounds of testing but might be best to leave it in seeing as the request payload size can depend on number of managed resources. Basically Akka HTTP won't process very large payload sizes by default as DDOS prevention tactic.
| resource: ingresses | ||
| updateStrategy: | ||
| method: InPlace | ||
| childResources: [] |
There was a problem hiding this comment.
this isn't necessary here as we control that internally in our multi cluster deploy repo
| @@ -25,7 +25,7 @@ | |||
| }, | |||
| "childResources": [ | |||
| { | |||
| "apiVersion": "extensions/v1beta1", | |||
| "apiVersion": "networking.k8s.io/v1beta1", | |||
There was a problem hiding this comment.
Is this correct? Why not: networking.k8s.io/v1
There was a problem hiding this comment.
kubectl get ingress now prefers the networking.k8s.io/v1 over extensions/v1beta1 (deprecated since v1.14). To explicitly request the deprecated version, use kubectl get ingress.v1beta1.extensions. (#94309, @liggitt) [SIG API Machinery and CLI]
There was a problem hiding this comment.
I think networking.k8s.io/v1 wasn't working when I tried it. It's a few weeks ago now though.
There was a problem hiding this comment.
Ah looks like it jsut went stable in 1.19 maybe?
https://kubernetes.io/docs/concepts/services-networking/ingress/
|
Docker image "registry-write.opensource.zalan.do/fabric/gateway-k8s-operator-review:pr-62-31" is not based on an approved base image. Any production deployment relying on this image will be blocked. To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Open Source Registry namespace |
|
Docker image "registry-write.opensource.zalan.do/fabric/gateway-e2e-tests:pr-62-31" is not based on an approved base image. Any production deployment relying on this image will be blocked. To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Open Source Registry namespace |
* Update static apiVersion used * Update associated tests Signed-off-by: bmooney <[email protected]>
* Use correct new version Signed-off-by: bmooney <[email protected]>
* Need to update CompositeController to manage new resources * Remove reference to old version from test resources Signed-off-by: bmooney <[email protected]>
* Temp test on SPP-Test Signed-off-by: bmooney <[email protected]>
* Back to the playground Signed-off-by: bmooney <[email protected]>
* Try to accept all states Signed-off-by: bmooney <[email protected]>
* Try to accept all states Signed-off-by: bmooney <[email protected]>
* Update docs Signed-off-by: bmooney <[email protected]>
* Undo rebase mistake Signed-off-by: bmooney <[email protected]>
* Add apiVersion to models Signed-off-by: bmooney <[email protected]>
* Migrate names Signed-off-by: bmooney <[email protected]>
* Fix tests Signed-off-by: bmooney <[email protected]>
* DNS Compliant naming Signed-off-by: bmooney <[email protected]>
* Bump entity parsing limits Signed-off-by: bmooney <[email protected]>
* Disable entity parsing limits Signed-off-by: bmooney <[email protected]>
* MOAR POWER Signed-off-by: bmooney <[email protected]>
* Attempt with two CCs Signed-off-by: bmooney <[email protected]>
* DNS compliant name for CC Signed-off-by: bmooney <[email protected]>
* Control all resources Signed-off-by: bmooney <[email protected]>
* Another test Signed-off-by: bmooney <[email protected]>
* Another test Signed-off-by: bmooney <[email protected]>
* Another test Signed-off-by: bmooney <[email protected]>
* Demo Signed-off-by: bmooney <[email protected]>
* Tidy Up PR for review Signed-off-by: bmooney <[email protected]>
* Bump from v1beta1 to v1 Signed-off-by: bmooney <[email protected]>
* Rebase fixes Signed-off-by: bmooney <[email protected]>
Signed-off-by: bmooney [email protected]