Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipper: require unique hosts in RouteGroup CRD #7242

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

AlexanderYastrebov
Copy link
Member

@AlexanderYastrebov AlexanderYastrebov commented Apr 3, 2024

See changes szuecs/routegroup-client#41

Skipper webhook currently requires unique hosts so this is a safe change.

@AlexanderYastrebov AlexanderYastrebov added the minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call. label Apr 3, 2024
@szuecs
Copy link
Member

szuecs commented Apr 3, 2024

👍

1 similar comment
@mikkeloscar
Copy link
Contributor

👍

@mikkeloscar mikkeloscar merged commit 3dbd20a into dev Apr 3, 2024
10 checks passed
@mikkeloscar mikkeloscar deleted the routegroup/update-crd-unique-hosts branch April 3, 2024 14:04
This was referenced Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/alpha merged/beta merged/kube-1.28 merged/stable minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants