Special form #2: Support selection vector for kernel execution#50
Open
zanmato1984 wants to merge 8 commits intomainfrom
Open
Special form #2: Support selection vector for kernel execution#50zanmato1984 wants to merge 8 commits intomainfrom
zanmato1984 wants to merge 8 commits intomainfrom
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
zanmato1984
commented
Aug 21, 2025
Owner
Author
zanmato1984
left a comment
There was a problem hiding this comment.
Consider moving the gather/scatter surrounding to a defaulted SelectiveExec, so that the function in exec.cc can be simplified.
0cce8c3 to
99a3217
Compare
99a3217 to
99098d2
Compare
99098d2 to
c005bbb
Compare
469ead1 to
9a1c49e
Compare
966d999 to
9072a34
Compare
9072a34 to
7c26ec8
Compare
7c26ec8 to
6e5186b
Compare
Co-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
This reverts commit db970f1e89722dcf65b09553c51ed1b1a4ede3ce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how to contribute here:
Please remove this line and the above text before creating your pull request.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)