[CASE-23] Harden Flight payload serialization checks for apache/arrow#49549#68
Closed
zanmato1984 wants to merge 5 commits intomainfrom
Closed
[CASE-23] Harden Flight payload serialization checks for apache/arrow#49549#68zanmato1984 wants to merge 5 commits intomainfrom
zanmato1984 wants to merge 5 commits intomainfrom
Conversation
…e from gRPC transport
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
zanmato1984
force-pushed
the
case-23-pr-49549-fixes
branch
from
89eb37d to
551dd88
Compare
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
Owner
Author
|
Closing this fork PR because Omar CASE-23 is being reset from fix-flow to review-mode for apache#49549. This branch/PR is superseded by review-only handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: follow-up fixes for upstream PR https://github.com/apache/arrow/pull/49549\n\nThis branch adds robustness checks and tests in Flight transport-agnostic serialization:\n- validate payload invariants before serialization\n- reject missing IPC metadata and mismatched body length\n- use bounds-safe buffer slicing for zero-copy reads\n- guard against deserializing payload buffers larger than 2GiB\n- add regression tests for invalid payload cases\n\nLocal validation:\n- ./cpp/build/debug/arrow-flight-internals-test '--gtest_filter=FlightSerialization.*'\n- ./cpp/build/debug/arrow-flight-internals-test '--gtest_filter=GrpcTransport.FlightDataDeserialize'\n- ./cpp/build/debug/arrow-flight-internals-test