GH-49272: Include windows_compatibility.h in thread_pool_test#71
Open
zanmato1984 wants to merge 1 commit intocontext/gh-49462-upstream-headfrom
Open
GH-49272: Include windows_compatibility.h in thread_pool_test#71zanmato1984 wants to merge 1 commit intocontext/gh-49462-upstream-headfrom
zanmato1984 wants to merge 1 commit intocontext/gh-49462-upstream-headfrom
Conversation
zanmato1984
force-pushed
the
fix/gh-49462-thread-pool-test-windows-include
branch
from
63e06ed to
ceb3dab
Compare
zanmato1984
changed the base branch from
main
to
context/gh-49462-upstream-head
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
zanmato1984
force-pushed
the
fix/gh-49462-thread-pool-test-windows-include
branch
from
ceb3dab to
2ab11ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arrow/util/windows_compatibility.hinclude tocpp/src/arrow/util/thread_pool_test.ccGetLastError()regression test buildable when it referencesSetLastError,GetLastError,DWORD, andERROR_*Context
This is a small follow-up branch for apache#49462. The upstream PR already adds the Windows last-error preservation logic and the new regression test; this branch only supplies the missing compatibility include needed by that test.
Validation
./debug/arrow-json-test --gtest_filter=ReaderTest.MultipleChunksParallelRegression./debug/arrow-threading-utility-test --gtest_filter=TestThreadPool.*Owns*