Fix ZFPY contiguous array error when used in Zarr
#811
+13
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #812
With Zarr v3 and using
zarr.codecs.ZFPYas serializer, the ZFP compressor logic innumcodecscomplains that it is not F-order data. The chunk data neither C/F contiguous when it is a sliced view of an existing array. I traced it down to the logic here, and this PR addresses the issue.numcodecs/numcodecs/zfpy.py
Lines 80 to 87 in e0ddee6
By making the check more explicit and applying
np.ascontiguousafter ensuring it not F-order, the issue goes away.Reproducer
Raises:
If we look at the chunk slices' numpy flags:
TODO: