Skip to content

V2 groups #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Oct 23, 2025
Merged

V2 groups #25

merged 21 commits into from
Oct 23, 2025

Conversation

brokkoli71
Copy link
Member

@brokkoli71 brokkoli71 commented Sep 30, 2025 •
edited
Loading

This PR adds:

  • Groups for v2 (fixes [v2] Groups #19)
  • static open function that auto-detects the Zarr version
  • remove zarrita from tests
  • add missing static create and open methods to match JZarr (with Path and String representation of Store)
  • replace print statements with assertions in some v3 tests
  • Tests for datatypes and fixed BytesCodec encode, decode for bool, float, double

Furthermore, the multi-inheritance strategy of v3.Array from core.Array and v3.Node was changed so that v3.Node is now an interface and core.Array is now an abstract class. Similar changes were made to v3.Codec, v2.Codec, and v2.Array.

@brokkoli71 brokkoli71 mentioned this pull request Sep 30, 2025
Merged
5 tasks
@brokkoli71 brokkoli71 marked this pull request as draft September 30, 2025 11:26
@normanrz normanrz changed the base branch from main to v2-core-features September 30, 2025 13:14
@brokkoli71 brokkoli71 changed the base branch from v2-core-features to main October 2, 2025 18:11
@brokkoli71 brokkoli71 marked this pull request as ready for review October 6, 2025 14:44
dominikl
dominikl reviewed Oct 7, 2025
View reviewed changes
@brokkoli71 brokkoli71 mentioned this pull request Oct 13, 2025
Open
@brokkoli71 brokkoli71 requested a review from normanrz October 13, 2025 19:46
@brokkoli71 brokkoli71 requested a review from dominikl October 13, 2025 19:46
@brokkoli71 brokkoli71 self-assigned this Oct 13, 2025
normanrz
normanrz reviewed Oct 22, 2025
View reviewed changes
@brokkoli71 brokkoli71 merged commit e101af0 into main Oct 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@normanrz normanrz normanrz approved these changes

@dominikl dominikl Awaiting requested review from dominikl

Assignees

@brokkoli71 brokkoli71

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v2] Groups

3 participants

@brokkoli71 @normanrz @dominikl