Replace redundant list comprehension with generator #3040
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
dstansby
previously approved these changes
May 8, 2025
tests/test_group.py
Outdated
| x | ||
| async for x in create_hierarchy( | ||
| store=store, nodes={"node": new_metadata}, overwrite=False | ||
| ) |
There was a problem hiding this comment.
CI fails with:
FAILED tests/test_group.py::test_create_hierarchy_existing_nodes[zarr2-async-array-memory] - TypeError: 'async_generator' object is not iterable
FAILED tests/test_group.py::test_create_hierarchy_existing_nodes[zarr2-async-group-memory] - TypeError: 'async_generator' object is not iterable
FAILED tests/test_group.py::test_create_hierarchy_existing_nodes[zarr3-async-array-memory] - TypeError: 'async_generator' object is not iterable
FAILED tests/test_group.py::test_create_hierarchy_existing_nodes[zarr3-async-group-memory] - TypeError: 'async_generator' object is not iterable
I think I need to change tuple( into await tuple(:
There was a problem hiding this comment.
Actually, this cannot work. There is no such thing as a "tuple comprehension":
Aggregating an async generator to a tuple
auto-merge was automatically disabled
May 8, 2025 12:12
Head branch was pushed to by a user without write access
DimitriPapadopoulos
force-pushed
the
PYL-R1728
branch
2 times, most recently
from
273f16a to
4db0587
Compare
DimitriPapadopoulos
force-pushed
the
PYL-R1728
branch
from
4db0587 to
901610d
Compare
There is no such thing as a "tuple comprehension": https://stackoverflow.com/questions/52285419/aggregating-an-async-generator-to-a-tuple#52285420 Fixes CI error: FAILED tests/test_group.py::test_create_hierarchy_existing_nodes[zarr2-async-array-memory] - TypeError: 'async_generator' object is not iterable
DimitriPapadopoulos
force-pushed
the
PYL-R1728
branch
from
901610d to
9341f6e
Compare
dstansby
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
docs/user-guide/*.rstchanges/