-
-
Notifications
You must be signed in to change notification settings - Fork 336
[RFC] Use mkdocs-material for Zarr-Python documentation #3118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I love the way this looks! Thanks so much for working on this. |
Apologies, I thought I had 👍'd previously. Now doing that retroactively in a general sense of the move and specifically for the style & the use of markdown. But I agree that we need a careful review of the pages (and personally, I liked the cards on the landing page) |
Thanks a lot for working on this, @maxrjones! I love the switch from
I'm with Josh on this one. Can we also add cards in mk-docs? |
While I prefer the no-cards version, I also believe it's preferable to decide based on the ease of use for people who aren't extremely familiar with the Zarr-Python documentation, because those people may be completely blocked or dissuaded from using the library whereas others will likely find their way anyways. I could do some polling on preferences if others agree with this philosophy. I also think that the transition to mkdocs shouldn't be blocked by whether the home page has cards. If people think this'll take a while to decide on, I could add this style card for now to minimize the stylistic decisions included in this PR. |
I just spent some time here and wanted to give a big 👍 to the switch to mkdocs-material. I wanted to do this leading up to 3.0 but choose not to in order to avoid scope creep in the documentation update. As for cards, I don't think this should bend the decision here either way. We should optimize for usability. If users can quickly find their way to the main sections of the docs, then I'm for dropping the cards. |
fwiw, using only markdown in sphinx docs is easy to do these days, including automatically running executable jupytext notebooks, which we use in the napari docs. Example page: https://github.com/napari/docs/blob/main/docs/howtos/layers/image.md?plain=1 Output: https://napari.org/stable/howtos/layers/image.html Never been a fan of the material look, but maybe I'm just weird. I'd prefer contributing upstream to the pydata sphinx theme (including customisation options) vs switching to a completely different ecosystem. Completely happy to be outvoted here, just wanted to add an alternative viewpoint in case there's more people like me out there. 😂 |
(in short, out of all the motivations, I only find the yaml configuration compelling...) |
Thank you so much to everyone who's expressed opinions so far! I'd greatly appreciate if anyone still lurking could share your comments before July 3, 2025. The motivation for this deadline is that I'd like to make progress on this PR over the long weekend in the U.S. but only if the change to mkdocs seems likely to be accepted. |
I think this looks great 👍 Definitely like the markdown! Had good experiences with mkdocs previously as well. |
+1 to all of @jni's comments (including the "Completely happy to be outvoted here" bit; ultimately, ensuring that contributors are empowered and motivated to write good documentation is the most important thing. I can adapt if others prefer different systems). |
This PR switches the docs from sphinx to mkdocs-material (closes #2894)
Preview: https://zarr--3118.org.readthedocs.build/en/3118/
Motivation for using mkdocs-material
Changes
Apart from the conversion to markdown and configuration updates, I made the following changes:
Review request context
I'm not looking for a final review here, but rather a general consensus on whether it's worth spending the time that'd be needed for the last 20% of polish.
TODO
changes/