-
Notifications
You must be signed in to change notification settings - Fork 2
Changed: #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changed: #14
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,10 +2,13 @@ export const COLOR_VARS = ` | |
| --fg-p: #202020; | ||
| --fg-a: #72B3AC; | ||
| --fg-m: #8D8D8D; | ||
| --fg-b: #2E7CF6; | ||
| --fg-placeholder: #BABABA; | ||
| --fc-w: #FFFFFF; | ||
| --bg-p: #00AA98; | ||
| --bg-s: #515151; | ||
| --bg-m: #FFFFFF; | ||
| --bg-l: #00B5A1; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these new colors are not used. remove them |
||
| --br-p: #C4C4C4; | ||
| `; | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,10 +2,13 @@ import styled from "@emotion/styled"; | |
|
|
||
| export const Input = styled.input` | ||
| width: 100%; | ||
| height: 40px; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't like the idea of fixing a height. remove this, it looks good enough |
||
| border: 1px solid var(--br-p); | ||
| border-radius: 4px; | ||
| box-sizing: border-box; | ||
| padding: 1em; | ||
| font-size: var(--fs-m); | ||
| background: transparent; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure why we should set this |
||
|
|
||
| &::placeholder { | ||
| color: var(--fg-placeholder); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,16 @@ import { Link as RouterLink } from "react-router-dom"; | |
|
|
||
| export const Anchor = styled("a")` | ||
| color: var(--fg-a); | ||
| font-weight: var(--fw-b); | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it should not be bold by default. it is bold only in events list - set it there |
||
| font-size: var(--fs-m); | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. font size should inherit from context |
||
| text-decoration: none; | ||
| display: inline-block; | ||
| padding: 0 0 11px; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. display and padding don't make sense here for me. give a reason for these changes or revert them |
||
| transition: 0.3s; | ||
|
|
||
| &:hover { | ||
| text-decoration: underline; | ||
| } | ||
| `; | ||
|
|
||
| export const Link = Anchor.withComponent(RouterLink); | ||
| export const Link = Anchor.withComponent(RouterLink); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove these 2 spaces