Add /rename builtin slash command by daniel-agentee · Pull Request #287 · zed-industries/codex-acp

daniel-agentee · 2026-05-14T12:27:23Z

Summary

Adds /rename <new title> as a builtin slash command for codex-acp. Typing /rename Foo in any ACP client (including stock Zed.app -- no client-side change required) renames the current session: the title is persisted to session_index.jsonl, the SQLite state DB is updated, and the client repaints its session list inline via the SessionInfoUpdate notification.

Empty argument prints a usage hint instead of being a silent no-op. The new builtin is added to builtin_command_names() so a same-named skill cannot shadow it.

Why

Today users can rename a session only by opening the title editor in the agent panel header, which depends on Zed having merged the title-editor wiring and on the protocol/handler PRs landing. A slash command works from any ACP client immediately because the dispatch lives entirely inside codex-acp.

What's in this PR

thread.rs:
- Adds rename to builtin_command_names() and builtin_commands() with an Unstructured("new session title") input hint so the / picker shows the argument slot.
- In handle_prompt, intercepts /rename before the Op::UserInput dispatch. Empty arg -> Usage: agent message. Non-empty -> calls self.handle_set_title(title, Some(title)), which already persists + emits SessionInfoUpdate, then sends a confirmation chunk. Returns StopReason::EndTurn immediately and never reaches the model.
New unit tests: rename_is_listed_in_builtin_commands, slash_rename_without_arg_shows_usage_message, slash_rename_with_arg_writes_title_to_session_index.

Tests

cargo fmt --all -- --check
cargo test --locked --lib
cargo check --locked
cargo clippy --all-targets --all-features -- -D warnings
git diff --check

37 lib tests pass.

Dependencies (drafted until merged)

This PR is intentionally split out as a separate, smaller concern from the underlying rename infrastructure. It stacks on:

Expose Codex skills as ACP slash commands #279 -- Expose Codex skills as ACP slash commands.
Handle session/setTitle and emit SessionInfoUpdate #286 -- Handle session/setTitle and emit SessionInfoUpdate.
Add session/setTitle method agentclientprotocol/agent-client-protocol#1199 -- the protocol-level companion.

I'll mark this PR ready-for-review and rebase to a clean single-commit diff once the dependencies land.

daniel-agentee · 2026-06-02T10:11:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00deaa9fd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-02T10:14:54Z

+                self.refresh_skills().await;
+                self.client
+                    .send_notification(SessionUpdate::AvailableCommandsUpdate(
+                        AvailableCommandsUpdate::new(self.available_commands()),
                    ));


Delay command updates until the session is visible

When session/new or session/load calls thread.load().await, this actor now sends AvailableCommandsUpdate immediately after resolving the internal oneshot, but before CodexAgent has responded to the outer ACP request with the session ID. The previous delayed task avoided this ordering problem. In clients that ignore or cannot attach updates for sessions they have not finished creating/loading yet, this notification can be dropped, leaving the slash-command palette without the builtins/skills until another update happens.

Useful? React with 👍 / 👎.

Addressed in d47615e by restacking #287 on the updated #279 tip (6bbb49f).

The available-commands update is delayed again so session/new / session/load callers can finish attaching the session before the notification arrives, but it is computed only after refresh_skills() from the current cache. That preserves the ordering behavior without reintroducing the stale pre-refresh snapshot. Local validation is green: cargo fmt --all -- --check, cargo test --locked --lib, cargo check --locked, cargo clippy --all-targets --all-features -- -D warnings, and git diff --check.

daniel-agentee · 2026-06-02T10:30:10Z

@codex review

daniel-agentee · 2026-06-02T10:34:08Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d47615e2d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-02T10:34:13Z

+        self.cached_implicit_invocation_skills
+            .iter()
+            .find(|s| s.name == name)


Rewrite explicit-only skill slash commands

The advertised command list includes every enabled skill, but this lookup only matches cached_implicit_invocation_skills. For a skill with policy.allow_implicit_invocation: false, the user will still see and select /skill-name, but the prompt is not rewritten to $skill-name; it is sent to Codex as plain /skill-name text, so explicit-only skills exposed by the slash menu are not actually invoked despite the README saying selection is equivalent to $name.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d31a62724

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-02T10:36:59Z

+                            .handle_set_title(title.to_owned(), Some(title.to_owned()))
+                            .await


Sync /rename titles to the state DB

When a user invokes the new /rename slash command in a normal session with SQLite state enabled, this path only calls handle_set_title, which appends to session_index.jsonl but never updates the StateDb row. The ACP session/setTitle path explicitly calls state_db.update_thread_title(...) before appending the index, so /rename leaves state_*.sqlite with the old title; any resume/search/listing surface that reads the SQLite metadata directly can keep showing or resolving the stale name after a successful rename.

Useful? React with 👍 / 👎.

Addressed in feec0b3 as well. The slash /rename path now uses the same SQLite state DB title update that ACP session/setTitle relies on, then appends to the legacy session_index.jsonl title index and notifies the client. Local validation is green: cargo fmt --all -- --check, cargo test --locked --lib (37 tests), cargo check --locked, cargo clippy --all-targets --all-features -- -D warnings, and git diff --check.

daniel-agentee · 2026-06-02T10:40:55Z

@codex review

chatgpt-codex-connector · 2026-06-02T10:46:49Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

daniel-agentee · 2026-06-02T11:45:55Z

Restacked this branch in bbd2042 so it now includes the refreshed #279 skill-root/duplicate-skill fixes and the refreshed #286 set-title auth/capability fixes before the /rename commit. Local validation is green: cargo fmt --all -- --check, cargo test --locked --lib (39 tests), cargo check --locked, cargo clippy --all-targets --all-features -- -D warnings, and git diff --check.

@codex review

chatgpt-codex-connector · 2026-06-02T11:49:20Z

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

daniel-agentee · 2026-06-02T14:36:02Z

Restacked again in 7cf7167 to include the #279 repo-local skill loader fix (4cb94d3) on top of the refreshed #279/#286 stack, then kept /rename on top. Local validation is green: cargo fmt --all -- --check, cargo test --locked --lib (40 tests), cargo check --locked, cargo clippy --all-targets --all-features -- -D warnings, and git diff --check.

@codex review

daniel-agentee · 2026-06-02T14:39:18Z

Restacked once more in 0ce206b to include #279’s duplicate-name slash command fix (1e212ef) along with the repo-local skill loader fix and the refreshed #286 set-title stack. Local validation is green: cargo fmt --all -- --check, cargo test --locked --lib (41 tests), cargo check --locked, cargo clippy --all-targets --all-features -- -D warnings, and git diff --check.

@codex review

chatgpt-codex-connector · 2026-06-02T14:43:54Z

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ce206bbe9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-02T17:29:22Z

+            let title = match thread_titles.get(&thread_id) {
+                Some(Some(title)) => Some(title.clone()),
+                Some(None) | None => first_user_message.as_deref().and_then(format_session_title),


Preserve cleared titles in session lists

When a title is cleared via session/setTitle with a blank value, append_thread_name records an empty thread_name, and find_latest_thread_titles_by_ids returns Some(None) for that thread. This branch treats that the same as no custom-title entry and falls back to first_user_message, so after the next session/list refresh a cleared title reappears as the generated first-message title even though the client was notified that the title was cleared.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a78550a86b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

daniel-agentee · 2026-06-02T23:04:33Z

This branch is supposed to be /rename-only: one commit on top of #286 (the session/setTitle + SessionInfoUpdate work), without the "Expose Codex skills as ACP slash commands" commit from #279. They're kept separate so each can be reviewed and merged on its own.

I just re-pushed it in that clean state. Flagging it because the branch has been rebased twice now with the #279 skills commit pulled back in (last on 2026-06-02), which bundles two unrelated features together and makes the diff much bigger than it needs to be. Is something automated rebasing this branch? If so, could it start from this /rename-on-#286 commit instead of the old skills-rooted stack? Happy to keep it rebased on #286 as the PR evolves.

daniel-agentee · 2026-06-03T12:47:04Z

Restacked /rename in b57de84 on top of the updated #286 head (cd654ff) while keeping this PR /rename-only. Local validation is green: cargo fmt --all -- --check, cargo test --locked --lib (34 tests), cargo check --locked, cargo clippy --all-targets --all-features -- -D warnings, and git diff --check.

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b57de84cac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

daniel-agentee · 2026-06-03T14:23:04Z

@codex review

chatgpt-codex-connector · 2026-06-03T14:26:55Z

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Previously the title was persisted to session_index.jsonl but the connected client (Zed) only saw the change on the next session/list refresh — usually after restart. Send a SessionUpdate::SessionInfoUpdate carrying the new title so the client can update its session list in place, no restart needed. Covers both rename surfaces: the session/setTitle JSON-RPC and the /rename builtin slash command both flow through handle_set_title.

daniel-agentee · 2026-06-09T08:05:14Z

Rebased this onto the refreshed #286 stack (fb86d53) and current origin/main (bb59050) to clear the merge conflict. The PR head is now 749e71e.

Validation after the rebase:

cargo fmt --all -- --check
git diff --check
CARGO_TARGET_DIR=/Users/danielstojanovic/Documents/Codex/2026-05-28/update-this-pr-and-make-it/codex-acp/target/pr286-check cargo check --locked
CARGO_TARGET_DIR=/Users/danielstojanovic/Documents/Codex/2026-05-28/update-this-pr-and-make-it/codex-acp/target/pr286-check cargo test --locked --lib (34 passed)

@codex review

Exposes `/rename <new title>` so users can rename the current ACP session from the chat input without a title-editor UI in the client. Works on stock Zed because the command resolves entirely inside codex-acp via the existing handle_set_title path that writes to $CODEX_HOME/session_index.jsonl and emits a SessionInfoUpdate so the client repaints its session list inline. The empty-arg case prints a usage hint instead of a silent no-op.

chatgpt-codex-connector · 2026-06-09T08:11:57Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

daniel-agentee · 2026-06-09T08:13:12Z

Restacked this on top of the updated #286 head (2c5497a) after the title-notification normalization fix. The PR head is now 9306582.

Validation:

cargo fmt --all -- --check
git diff --check
CARGO_TARGET_DIR=/Users/danielstojanovic/Documents/Codex/2026-05-28/update-this-pr-and-make-it/codex-acp/target/pr286-check cargo check --locked
CARGO_TARGET_DIR=/Users/danielstojanovic/Documents/Codex/2026-05-28/update-this-pr-and-make-it/codex-acp/target/pr286-check cargo test --locked --lib (35 passed)

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9306582f18

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-09T08:16:25Z

+                            .send_agent_text("Usage: /rename <new session title>\n");
+                    } else {
+                        match self
+                            .handle_set_title(title.to_owned(), Some(title.to_owned()))


Normalize /rename title notifications

When /rename is used with a title containing a newline/CR or more than 120 graphemes, this passes the raw trimmed title into SessionInfoUpdate, but session/list displays titles via stored_session_title/format_session_title in src/codex_agent.rs, which replaces newlines and truncates. That means the client repaints to a different inline title than it will show after the next list/reload, bypassing the title-notification normalization fix; use the same notification formatting here before calling handle_set_title.

Useful? React with 👍 / 👎.

Addressed in c13d0d9. /rename now formats the SessionInfoUpdate title through the same trim/newline/truncation path used for listed titles while keeping the persisted title unchanged. Added rename_notification_title_matches_session_list_formatting and extended the slash rename regression to assert the normalized SessionInfoUpdate. Validation is green: cargo fmt --all -- --check, git diff --check, CARGO_TARGET_DIR=/Users/danielstojanovic/Documents/Codex/2026-05-28/update-this-pr-and-make-it/codex-acp/target/pr286-check cargo check --locked, and CARGO_TARGET_DIR=/Users/danielstojanovic/Documents/Codex/2026-05-28/update-this-pr-and-make-it/codex-acp/target/pr286-check cargo test --locked --lib (36 passed).

daniel-agentee · 2026-06-10T02:11:36Z

Pushed c13d0d9 to address the latest Codex review feedback on /rename title notifications.

Validation:

cargo fmt --all -- --check
git diff --check
CARGO_TARGET_DIR=/Users/danielstojanovic/Documents/Codex/2026-05-28/update-this-pr-and-make-it/codex-acp/target/pr286-check cargo check --locked
CARGO_TARGET_DIR=/Users/danielstojanovic/Documents/Codex/2026-05-28/update-this-pr-and-make-it/codex-acp/target/pr286-check cargo test --locked --lib (36 passed)

@codex review

chatgpt-codex-connector · 2026-06-10T02:14:56Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

benbrandt · 2026-06-23T15:19:46Z

Hi thanks for taking the time to dig in!
Development is moving to agentclientprotocol/codex-acp. The new adapter is built on the new Codex App Server, and we are pooling implementation and maintenance work across teams there. If this is still needed, please open a PR for that one. Thanks!

daniel-agentee force-pushed the acp-rename-slash branch from 0f258a0 to e911a5f Compare May 15, 2026 15:29

daniel-agentee mentioned this pull request May 15, 2026

Handle session/setTitle and emit SessionInfoUpdate #286

Closed

daniel-agentee force-pushed the acp-rename-slash branch from e911a5f to 00deaa9 Compare June 2, 2026 10:11

chatgpt-codex-connector Bot reviewed Jun 2, 2026

View reviewed changes

daniel-agentee mentioned this pull request Jun 2, 2026

Add session/setTitle method agentclientprotocol/agent-client-protocol#1199

Open

daniel-agentee force-pushed the acp-rename-slash branch from 00deaa9 to d47615e Compare June 2, 2026 10:29

daniel-agentee force-pushed the acp-rename-slash branch from d47615e to 0d31a62 Compare June 2, 2026 10:34

chatgpt-codex-connector Bot reviewed Jun 2, 2026

View reviewed changes

daniel-agentee force-pushed the acp-rename-slash branch from 0d31a62 to feec0b3 Compare June 2, 2026 10:40

daniel-agentee force-pushed the acp-rename-slash branch from feec0b3 to bbd2042 Compare June 2, 2026 11:45

daniel-agentee force-pushed the acp-rename-slash branch from bbd2042 to 7cf7167 Compare June 2, 2026 14:35

daniel-agentee force-pushed the acp-rename-slash branch from 7cf7167 to 0ce206b Compare June 2, 2026 14:39

daniel-agentee marked this pull request as ready for review June 2, 2026 17:26

chatgpt-codex-connector Bot reviewed Jun 2, 2026

View reviewed changes

daniel-agentee force-pushed the acp-rename-slash branch from 0ce206b to a78550a Compare June 2, 2026 23:01

chatgpt-codex-connector Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread src/codex_agent.rs

daniel-agentee force-pushed the acp-rename-slash branch from a78550a to b57de84 Compare June 3, 2026 12:46

chatgpt-codex-connector Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread src/thread.rs

daniel-agentee force-pushed the acp-rename-slash branch from b57de84 to 508f104 Compare June 3, 2026 14:22

daniel-agentee added 7 commits June 9, 2026 09:04

Handle ACP session/setTitle and rename underlying Codex thread

09563b0

Support title updates for unloaded sessions

a6f7e34

Reject title updates for missing unloaded sessions

6fe8fc3

Normalize cleared title notifications

a976c41

Batch session title index lookups

c44dff4

Honor cleared titles in batched session list

fb86d53

daniel-agentee force-pushed the acp-rename-slash branch from 508f104 to 749e71e Compare June 9, 2026 08:04

daniel-agentee added 2 commits June 9, 2026 10:10

Normalize session title update notifications

2c5497a

daniel-agentee force-pushed the acp-rename-slash branch from 749e71e to 9306582 Compare June 9, 2026 08:12

chatgpt-codex-connector Bot reviewed Jun 9, 2026

View reviewed changes

Normalize slash rename title notifications

c13d0d9

benbrandt closed this Jun 23, 2026

		.handle_set_title(title.to_owned(), Some(title.to_owned()))
		.await

Uh oh!

Conversation

daniel-agentee commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

What's in this PR

Tests

Dependencies (drafted until merged)

Uh oh!

daniel-agentee commented Jun 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

daniel-agentee Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

daniel-agentee commented Jun 2, 2026

Uh oh!

daniel-agentee commented Jun 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

daniel-agentee Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

daniel-agentee commented Jun 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 2, 2026

Uh oh!

daniel-agentee commented Jun 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 2, 2026

Uh oh!

daniel-agentee commented Jun 2, 2026

Uh oh!

daniel-agentee commented Jun 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

daniel-agentee commented Jun 2, 2026

Uh oh!

daniel-agentee commented Jun 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

daniel-agentee commented Jun 3, 2026

daniel-agentee commented May 14, 2026 •

edited

Loading