Skip to content
This repository was archived by the owner on Jul 22, 2026. It is now read-only.

Add API command coverage tests - #328

Closed
jixianyihao wants to merge 1 commit into
zed-industries:mainfrom
jixianyihao:codex/api-command-tests
Closed

Add API command coverage tests#328
jixianyihao wants to merge 1 commit into
zed-industries:mainfrom
jixianyihao:codex/api-command-tests

Conversation

@jixianyihao

Copy link
Copy Markdown

Summary

  • Add an in-process ACP dispatch test that exercises all registered top-level agent request and notification handlers through the real ACP client connection.
  • Add focused tests for advertised slash commands, session config options, mode/config mutations, cancellation, replayed history, logout, and supported prompt content block mapping.
  • Keep the production ACP registration behavior intact by extracting the handler registration chain behind a small internal AgentApi abstraction for testability.

Validation

  • cargo fmt --check
  • cargo test

@jixianyihao
jixianyihao force-pushed the codex/api-command-tests branch from d8bbae9 to 2970f46 Compare June 18, 2026 16:13
@jixianyihao
jixianyihao marked this pull request as ready for review June 18, 2026 16:18
@jixianyihao
jixianyihao force-pushed the codex/api-command-tests branch from 2970f46 to de0b9c3 Compare June 18, 2026 23:18
@jixianyihao jixianyihao changed the title [codex] add API command coverage tests Add API command coverage tests Jun 18, 2026
@jixianyihao

Copy link
Copy Markdown
Author

Hi @benbrandt, could you take a look when you have a chance? This PR adds focused ACP API and slash-command coverage tests, with the new tests split into dedicated test modules.

@benbrandt

Copy link
Copy Markdown
Member

Hi thanks for taking the time to dig in!
Development is moving to agentclientprotocol/codex-acp. The new adapter is built on the new Codex App Server, and we are pooling implementation and maintenance work across teams there. If this is still needed, please open a PR for that one. Thanks!

@benbrandt benbrandt closed this Jun 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants