Skip to content

Respect ACP MCP tool timeout metadata#331

Closed
zerone0x wants to merge 1 commit into
zed-industries:mainfrom
zerone0x:orbit/e36d66fe-mcp-tool-timeout
Closed

Respect ACP MCP tool timeout metadata#331
zerone0x wants to merge 1 commit into
zed-industries:mainfrom
zerone0x:orbit/e36d66fe-mcp-tool-timeout

Conversation

@zerone0x

Copy link
Copy Markdown
Contributor

Summary

  • propagate ACP MCP server _meta.tool_timeout_sec / _meta.toolTimeoutSec into Codex McpServerConfig::tool_timeout_sec
  • accept numeric and string second values, including fractional seconds
  • add focused parser tests for valid and invalid timeout metadata

Fixes #308.

Verification

  • cargo fmt --check
  • git diff --check
  • cargo test mcp_tool_timeout_sec --lib (blocked in this container: Rust build scripts cannot link because no system linker/C runtime is installed; cc is missing, and rust-lld cannot find libc/gcc_s)

@zerone0x

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate; the same fix is tracked in #332.

@zerone0x zerone0x closed this Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can you support customizing the tool_timeout_sec parameter in McpServerConfig?

1 participant