Disable tools when building Broker as sub-project #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Projects that build Broker only as a dependency (like Zeek) have no use for the benchmark tools. Hence, those targets should be excluded from the build to avoid building superfluous binaries but also since they might cause build issues in some scenarios.
timwoj
approved these changes
Apr 28, 2024
0xxon
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects that build Broker only as a dependency (like Zeek) have no use for the benchmark tools. Hence, those targets should be excluded from the build to avoid building superfluous binaries but also since they might cause build issues in some scenarios.
@0xxon with this patch, Zeek builds in an Ubuntu 20.04 container again without issue.