adding new field mapping custom_field_symbol associative array, initi… #598
+229
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptomail
force-pushed
the
jteitelbaum/ticket_field_magic_mapping
branch
from
6df1c09 to
6895045
Compare
…alized from global meta data garnered from account context
cryptomail
force-pushed
the
jteitelbaum/ticket_field_magic_mapping
branch
from
01c4316 to
1cad2d1
Compare
Thomascountz
reviewed
Nov 3, 2025
Comment on lines
+512
to
+519
| def custom_field_symbol | ||
| @custom_field_symbol ||= CustomFieldSymbolProxy.new(self, @custom_field_symbol) | ||
| end | ||
|
|
||
| def custom_field_symbol=(val) | ||
| @custom_field_symbol = val | ||
| @custom_field_symbol_proxy = CustomFieldSymbolProxy.new(self, @custom_field_symbol) | ||
| end |
There was a problem hiding this comment.
custom_field_symbol= overwrites @custom_field_symbol with the raw array and caches a proxy in @custom_field_symbol_proxy, but the getter still memoizes on @custom_field_symbol. After the first assignment (or any mass-assignment that sets this ivar) subsequent reads return the plain array and ticket.custom_field_symbol['foo'] will raise a TypeError when trying to index an array with a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alized from global meta data garnered from account context