Skip to content

Conversation

kjeldahl
Copy link

🐕

/cc @zendesk/dingo

Description

Skip files in vendor just as files in tmp are skipped.

When installing gems using bundler on a CI system the gems end up in the vendor/bundle folder pr default and these files are not supposed to be included in the package, so they should be skipped. Also locally if installing gems in vendor/ I get a "Too many open files" error as each AppFile is opened upon instantiation.

Before merging this PR

  • Fill out the Risks section
  • Think about performance and security issues

Risks

  • [RUNTIME] Can this change affect apps rendering for a user?
  • [HIGH | medium | low] What features does this touch?

@kjeldahl kjeldahl requested review from a team as code owners May 19, 2022 10:33
kjeldahl added 3 commits May 23, 2022 08:32
When installing gems using bundler on a CI system the gems end up in the vendor/bundle folder pr default and these files are not supposed to be included in the package, so they should be skipped. Also locally if installing gems in vendor/ I get a "Too many open files" error as each AppFile is opened upon instantiation.

Some systems will not the path be changed: ruby/setup-ruby#136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant