hal: renesas: ra: Add support Renesas r_sci_b_spi #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial support for SCI SPI of Renesas RA Signed-off-by: Khoa Tran <[email protected]>
Add polling transfer support for SCI B SPI Signed-off-by: Khoa Tran <[email protected]>
thenguyenyf
reviewed
Sep 4, 2025
| * function calls: | ||
| **********************************************************************************************************************/ | ||
| fsp_err_t RP_SCI_B_SPI_WriteOneBytePolling (spi_ctrl_t * const p_api_ctrl, | ||
| const uint8_t tx_byte) |
There was a problem hiding this comment.
The indentation should be updated
| * function calls: | ||
| **********************************************************************************************************************/ | ||
| fsp_err_t RP_SCI_B_SPI_ReadOneBytePolling (spi_ctrl_t * const p_api_ctrl, | ||
| uint8_t * p_rx_byte) |
There was a problem hiding this comment.
Correct the indentation
Comment on lines
+154
to
+155
| while (!p_ctrl->p_reg->CSR_b.TEND) { | ||
| } |
There was a problem hiding this comment.
nits: The register wait should be done by FSP_HARDWARE_REGISTER_WAIT
Suggested change
| while (!p_ctrl->p_reg->CSR_b.TEND) { | |
| } | |
| FSP_HARDWARE_REGISTER_WAIT(p_ctrl->p_reg->CSR_b.TEND, 1) |
| * @return See @ref RENESAS_ERROR_CODES or functions called by this function for other possible return codes. This | ||
| * function calls: | ||
| **********************************************************************************************************************/ | ||
| fsp_err_t RP_SCI_B_SPI_StartTransferPolling (spi_ctrl_t * const p_api_ctrl) |
There was a problem hiding this comment.
Suggested change
| fsp_err_t RP_SCI_B_SPI_StartTransferPolling (spi_ctrl_t * const p_api_ctrl) | |
| fsp_err_t RP_SCI_B_SPI_StartTransferPolling (spi_ctrl_t * const p_api_ctrl) |
Please check and update similar cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support Renesas r_sci_b_spi