zephyr/soc: Add MediaTek DSPs#34
Merged
nashif merged 2 commits intozephyrproject-rtos:masterfrom Dec 2, 2024
Merged
Conversation
This was referenced Nov 26, 2024
Add HAL integration for mt8186/88 and mt8196 DSP processors. Also rename the existing mt8195 HAL directory to match the newer naming scheme in the Zephyr SOC family. Signed-off-by: Andy Ross <andyross@google.com>
First, recent Cadence toolchains have begun using the UINT32_C() to define constants, but don't include stdint.h to import it. And in any case the stdint.h headers in our toolchains aren't assembly-compatible. Give it a reasonable definition inline. Also, replace the use of the "addi.a" pseudoinstruction in the (unused by Zephyr) register context macros with a simple "addi". I'm unable to figure this one out, this isn't a documented mnemonic, it's not supported by any version of binutils (or even xt-clang in its default mode). When I disassemble the upstream HALs, I can verify that the emitted instruction for the sequence is a regular addi (though in the Cadence binaries it's packed in a VLIW bundle, which doesn't match the assembly source here...). My guess is that this is a hint for bundle packing, but I don't know. Regardless, our headers dating back into SOF have always just used "addi" here, which builds fine and will run compatibly. And again, Zephyr doesn't use this HAL feature anyway. Signed-off-by: Andy Ross <andyross@google.com>
andyross
force-pushed
the
mtk-updates
branch
from
dab93b7 to
d79ffd4
Compare
Collaborator
Author
nashif
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HAL integration for mt8186/88 and mt8196 DSP processors.