Skip to content

Conversation

@mathieuchopstm
Copy link
Contributor

Replace some manually-defined DT_COMPAT_<> Kconfig macro variables with their automatically generated counterparts. In most cases, this is straightforward as the manually defined macro is named identically to the one generated by the build system.

See also #100215

Replace some manually-defined DT_COMPAT_<> Kconfig macro variables with
their automatically generated counterparts. In most cases, this is
straightforward as the manually defined macro is named identically to the
one generated by the build system.

Signed-off-by: Mathieu Choplain <[email protected]>
@mathieuchopstm mathieuchopstm force-pushed the topic/cleanup_DT_COMPAT_kconfig/treewide branch from 7da38f0 to 7fa30cc Compare December 4, 2025 09:53
@mathieuchopstm
Copy link
Contributor Author

Fixed conflict from #100326 merge + use identical wording in modules/nrf_wifi/bus/Kconfig as what already existed in drivers/wifi/nrf_wifi/Kconfig.nrfwifi

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

@mathieuchopstm mathieuchopstm added the DNM This PR should not be merged (Do Not Merge) label Dec 8, 2025
@mathieuchopstm
Copy link
Contributor Author

#100215 caused regressions on STM32 platforms - DNM until investigated

Comment on lines -280 to -287
DT_COMPAT_NORDIC_NRF_SPIM := nordic,nrf-spim

config NRFX_SPIM
bool "SPIM driver"
depends on $(dt_has_compat,$(DT_COMPAT_NORDIC_NRF_SPIM))

DT_COMPAT_NORDIC_NRF_SPIS := nordic,nrf-spis

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think you can remove them. They are not the same as generated DT_HAS_"compatiple"_ENABLED macros and actually used below as arguments in dt_has_compat().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These macros are generated automatically by gen_driver_kconfig_dts.py - see <build dir>/Kconfig/Kconfig.dts.

This is a pattern already present in tree - see for example:

config AUDIO_CODEC_PCM1681_I2C
bool
default y
depends on $(dt_compat_on_bus,$(DT_COMPAT_TI_PCM1681),i2c)
help
I2C version of pcm1681xx driver

@mathieuchopstm
Copy link
Contributor Author

Removing DNM: there are no Kconfig.defconfig affected here so there should be no issues.
(see #100674 for details)

@mathieuchopstm mathieuchopstm removed the DNM This PR should not be merged (Do Not Merge) label Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants