drivers: display: SDL: Add SDL_DISPLAY_ROUNDED_MASK option #100231
+341
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `SDL_DISPLAY_ROUNDED_MASK` and `SDL_DISPLAY_ROUNDED_MASK_COLOR` Kconfig options to mask a elliptical area of the display. This is useful for prototyping alignments for rounded displays. Signed-off-by: Fabian Blatz <[email protected]>
zephyrbot
requested review from
JarmouniA,
VynDragon,
danieldegrasse and
jfischer-no
faxe1008
force-pushed
the
sdl_eliptic_display
branch
from
7b5c46e to
18430a3
Compare
Since the number of function arguments grows out of hand, place them into structs and pass a struct to the method instead. Signed-off-by: Fabian Blatz <[email protected]>
faxe1008
force-pushed
the
sdl_eliptic_display
branch
from
18430a3 to
4c00cb9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While designing some GUI for rounded displays, I encountered the convenience issue that I like to prototype my UIs in the native sim and only do a final check on actual hardware, since its much fast to iterate. Anyways for rounded displays its annoying to have to guess which part of the screen is not visible. It might not be completely pixel perfect but it allows for first good estimate:
On real hardware:
Note: the second commit may be considered optional, but at the point where the function takes 18 parameters it felt sensibly to add this refactoring.