Bluetooth: GATT: Use offset when GAP name is updated #100235
Open
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The offset in write_name function used by GAP service was really ignoring offset value. This commit updates it to use the offset in similar way how it is done in write_appearance function. Signed-off-by: Radosław Koppel <[email protected]>
zephyrbot
added
area: Bluetooth
area: Bluetooth Host
zephyrbot
requested review from
HaavardRei,
PavelVPV,
Thalley,
alwa-nordic,
cvinayak,
hermabe,
jhedberg,
rugeGerritsen and
sjanc
|
Thalley
requested changes
Nov 29, 2025
Comment on lines
+123
to
+137
| const char *current_name = bt_get_name(); | ||
| size_t current_name_len = strlen(current_name); | ||
|
|
||
| if (offset >= CONFIG_BT_DEVICE_NAME_MAX) { | ||
| if (offset > current_name_len) { | ||
| return BT_GATT_ERR(BT_ATT_ERR_INVALID_OFFSET); | ||
| } | ||
|
|
||
| if (offset + len > CONFIG_BT_DEVICE_NAME_MAX) { | ||
| return BT_GATT_ERR(BT_ATT_ERR_INVALID_ATTRIBUTE_LEN); | ||
| } | ||
|
|
||
| memcpy(value, buf, len); | ||
| memcpy(value, current_name, current_name_len + 1); | ||
| memcpy(value + offset, buf, len); | ||
|
|
||
| value[len] = '\0'; | ||
| value[offset + len] = '\0'; |
Contributor
There was a problem hiding this comment.
I understand the + offset changes that seem valid, but why do we care about current_name and current_name_len?
| size_t current_name_len = strlen(current_name); | ||
|
|
||
| if (offset >= CONFIG_BT_DEVICE_NAME_MAX) { | ||
| if (offset > current_name_len) { |
Contributor
There was a problem hiding this comment.
Correct me if I'm wrong, but isn't offset only used in long writes? Which require the characteristic to have BT_GATT_PERM_PREPARE_WRITE, but BT_GATT_CHARACTERISTIC(BT_UUID_GAP_DEVICE_NAME does not have that?
So in the current implementation, offset cannot be anything but 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offset in write_name function used by GAP service was really ignoring offset value.
This commit updates it to use the offset in similar way how it is done in write_appearance function.
Note: We should implement this solution or check if offset == 0.
Current implementation first allows offset > 0 and then totally ignores it when setting the name.