drivers: audio: dmic_mcux: remove arbitrary mapping of pdm to dmic channel #90824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Audio
platform: NXP Drivers
github-actions
bot
requested review from
dbaluta,
decsny,
dleach02,
kv2019i,
lgirdwood,
lyakh,
manuargue,
mmahadevan108 and
Raymond0225
…annel The dmic_mcux driver required a mapping of paired dmics to specify the same pdm number, and would arbitrarily assign the left channel of the pair to even dmic channel number and the right to an odd dmic channel number. Change this so that the pdm number in the mapping is used as the dmic channel number, and paired dmics are checked to specify consecutive pdm numbers (instead of the same pdm number). This allows users to control explicitly which dmic channel to use and whether that dmic channel is left or right, without this arbitrary indirect mapping. This is important in case they want a dmic that is wired to be right channel to be assigned to dmic channel 0, which is the only channel that supports hwvad. Signed-off-by: Mike J. Chen <[email protected]>
|
mjchen0
changed the title
dleach02
approved these changes
Jun 26, 2025
mmahadevan108
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dmic_mcux driver required a mapping of paired dmics to specify the same pdm number, and would arbitrarily assign the left channel of the pair to even dmic channel number and the right to an odd dmic channel number.
Change this so that the pdm number in the mapping is used as the dmic channel number, and paired dmics are checked to specify consecutive pdm numbers (instead of the
same pdm number).
This allows users to control explicitly which dmic channel to use and whether that dmic channel is left or right, without this arbitrary indirect mapping. This is important in case they want a dmic that is wired to be right channel to be assigned to dmic channel 0, which is the only channel that supports hwvad.