drivers: mbox_nxp_imx_mu: change send to return negative error #90828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: mbox
platform: NXP Drivers
github-actions
bot
requested review from
carlocaione,
dbaluta,
decsny,
dleach02,
ithinuel,
manuargue,
mmahadevan108,
Raymond0225 and
wearyzen
decsny
reviewed
May 30, 2025
mjchen0
force-pushed
the
mbox_nxp_imx_mu
branch
2 times, most recently
from
f33fbbc to
0ff229f
Compare
decsny
previously approved these changes
Jun 3, 2025
dbaluta
reviewed
Jun 3, 2025
decsny
approved these changes
Jun 5, 2025
|
@mjchen0 please rebase your PR to pull in the CI regression fix you are seeing. |
Change nxp_imx_mu_send() to return a negative errno value on error. The fsl_mu function MU_TriggerInterrupts() returns either kStatus_Success or kStatus_Fail, which have the value 0 or 1, respectively. kStatus_Fail should not be returned to the upper levels, which expect negative values for errors, so add a check for the return value of MU_TriggerInterrupts() and return an errno value on error. Signed-off-by: Mike J. Chen <[email protected]>
|
mmahadevan108
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change nxp_imx_mu_send() to return a negative errno value on error.
The fsl_mu function MU_TriggerInterrupts() returns either kStatus_Success or kStatus_Fail, which have the value 0 or 1, respectively. kStatus_Fail should not be returned to the upper levels, which expect negative values for errors, so add a check for the return value of
MU_TriggerInterrupts() and return an errno value on error.