Skip to content

Upstream/renesas ra input capture channel b pwm #90838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

duynguyenxa
Copy link
Member

This commit add support for input capture on GPT GTIOCnB pin for Renesas RA devices

@github-actions github-actions bot added platform: Renesas RA Renesas Electronics Corporation, RA area: PWM Pulse Width Modulation labels May 30, 2025
@duynguyenxa duynguyenxa force-pushed the upstream/renesas_ra_input_capture_channel_b_pwm branch from 3d569be to 1345d12 Compare May 30, 2025 03:24
Copy link
Contributor

@khoa-nguyen-18 khoa-nguyen-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have some comments regarding typos and duplicates.

Comment on lines 6 to 7
#ifndef ZEPHYR_INCLUDE_DT_BINDINGS_RENESAS_RZ_PWM_H_
#define ZEPHYR_INCLUDE_DT_BINDINGS_RENESAS_RZ_PWM_H_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#ifndef ZEPHYR_INCLUDE_DT_BINDINGS_RENESAS_RZ_PWM_H_
#define ZEPHYR_INCLUDE_DT_BINDINGS_RENESAS_RZ_PWM_H_
#ifndef ZEPHYR_INCLUDE_DT_BINDINGS_RENESAS_RA_PWM_H_
#define ZEPHYR_INCLUDE_DT_BINDINGS_RENESAS_RA_PWM_H_

@@ -166,8 +166,8 @@
&pwm1 {
pinctrl-0 = <&pwm1_default>;
pinctrl-names = "default";
interrupts = <63 1>, <64 1>;
interrupt-names = "gtioca", "overflow";
interrupts = <63 1>, <63 1>, <64 1>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate <63 1>

Comment on lines 41 to 42
interrupt-names:
required: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate interrupt-names: property, please remove this one

This commit add support for input capture feature for PWM GPT
on Renesas RA MCU on GTIOCB pin
This use the combination of input capture interrupt B and
overflow interrupt to get pulse and period information
This commit also add modify to all impact device tree config
using renesas,ra-pwm node

Signed-off-by: Duy Nguyen <[email protected]>
@duynguyenxa duynguyenxa force-pushed the upstream/renesas_ra_input_capture_channel_b_pwm branch from 1345d12 to 5d9d20a Compare May 30, 2025 09:43
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: PWM Pulse Width Modulation platform: Renesas RA Renesas Electronics Corporation, RA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants