move IronSide APIs from drivers/firmware to soc/nordic #91910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anangl,
jaz1-nordic,
kartben,
kl-cruz,
magp-nordic,
masz-nordic,
nashif and
nika-nordic
carlescufi
previously approved these changes
Jun 19, 2025
jonathannilsen
force-pushed
the
ironside-to-soc
branch
from
2ac6b57 to
53667e7
Compare
57300
force-pushed
the
ironside-to-soc
branch
2 times, most recently
from
86f4440 to
ab17f0c
Compare
github-actions
bot
requested review from
andyross,
ceolin,
cfriedt,
dcpleung,
npitre and
peter-mitsis
anangl
previously approved these changes
Jun 30, 2025
57300
previously approved these changes
Jun 30, 2025
carlescufi
previously approved these changes
Jul 1, 2025
|
@57300 is the 4.2 milestone here intentional? IE do you want this to be merged in before the RC2 as a "cosmetic change"? |
s/IRONside/IronSide/g Signed-off-by: Grzegorz Swiderski <[email protected]>
Move the IronSide APIs to soc/nordic from drivers/firmware since these are vendor specific APIs. The header files are now included from <nrf_ironside/*.h>. Adjust code that uses these APIs accordingly. Also move the DT binding for "nordic,ironside-call" from bindings/firmware to bindings/misc. Signed-off-by: Jonathan Nilsen <[email protected]>
Use designated IRQ numbers, instead of generic defaults. Signed-off-by: Grzegorz Swiderski <[email protected]>
57300
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Rebased to fix conflicts.
@danieldegrasse Yes, these are cosmetic changes we would like to get in for v4.2.0, because it will be the first Zephyr release with support for IronSide. Moving the API is also a part of resolving #91373.
anangl
approved these changes
Jul 2, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the IronSide APIs to soc/nordic from drivers/firmware since these are vendor specific APIs.
The header files are now included from <nrf_ironside/*.h>.
Adjust code that uses these APIs accordingly.
Also move the DT binding for "nordic,ironside-call" from bindings/firmware to bindings/misc.
Also includes a commit with some minor spelling adjustments before the move.