drivers: wifi: siwx91x: Fix AP stability bugs #91915
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the first commit, can you add For the second commit, I understand |
muahmed-silabs
force-pushed
the
fix/ap-stability-bugs
branch
from
973061e to
9bb395b
Compare
github-actions
bot
requested review from
asmellby,
jerome-pouiller,
jhedberg,
jukkar,
Kludentwo,
krish2718,
MaochenWang1,
Martinhoff-maker and
rlubos
Fixes: commit a73f202 ("drivers: wifi: siwx91x: Fix boot_config") Disabled the 160 MHz feature due to stability issues (mode change) Signed-off-by: Muzaffar Ahmed <[email protected]>
Raising event from driver itself after successful AP start, instead of waiting for an event from SDK/TA FW. TA used to send an asynchronous event earlier but currently does not. Signed-off-by: Muzaffar Ahmed <[email protected]>
Copy only WIFI_MAC_ADDR_LEN bytes to sta_info.mac instead of dynamic length Signed-off-by: Muzaffar Ahmed <[email protected]>
muahmed-silabs
force-pushed
the
fix/ap-stability-bugs
branch
from
9bb395b to
968a503
Compare
|
jhedberg
approved these changes
Jun 19, 2025
| @@ -885,14 +885,15 @@ static sl_status_t siwx91x_on_ap_sta_connect(sl_wifi_event_t event, void *data, | |||
| uint32_t data_length, void *arg) | |||
| { | |||
| ARG_UNUSED(event); | |||
| ARG_UNUSED(data_length); | |||
There was a problem hiding this comment.
To avoid any further mistake, it would probably make sense to explain what value is represented by data_length. Maybe the code should be:
struct ??? *station = arg;
[...]
ASSERT(data_length == sizeof(struct ???));
... and I assume the first field of struct ??? is the mac address of the station.
jerome-pouiller
approved these changes
Jun 19, 2025
asmellby
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.