Skip to content

tests: drivers: build_all: sensor: add more sensors #91928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025

Conversation

kartben
Copy link
Contributor

@kartben kartben commented Jun 19, 2025

add previously untested sensors

  • adi,adxl366
  • everlight,als-pt19
  • maxim,ds3231-sensor

I was going to also add brcm,afbr-s50 but it requires an Arm target ; it might still make sense to add a config for testing such kind of sensors, but this is for another PR I guess. However, I kept the commit that is fixing the yaml file for this sensor's binding so that the snippet in the documentation is complete (cc @ubieda @bperseghetti )

@kartben kartben changed the title tests: drivers: build_all: sensor: add brcm,afbr-s50 build test tests: drivers: build_all: sensor: add more sensors Jun 19, 2025
@kartben kartben force-pushed the AFBR branch 3 times, most recently from ba1d7fa to f943b11 Compare June 22, 2025 20:11
@kartben kartben marked this pull request as ready for review June 22, 2025 20:38
@github-actions github-actions bot added the area: Sensors Sensors label Jun 22, 2025
ubieda
ubieda previously approved these changes Jun 23, 2025
Copy link
Member

@ubieda ubieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. WRT adding the AFBR-S50 to the tests, we'd have to add test doubles to the HAL dependencies, as they're implemented by the binary blob.

If that sounds good. Let me know and I can take a stab at it.

pdgendt
pdgendt previously approved these changes Jun 23, 2025
@kartben kartben dismissed stale reviews from pdgendt and ubieda via b69e093 June 23, 2025 07:11
@kartben kartben requested review from pdgendt and ubieda June 23, 2025 07:12
pdgendt
pdgendt previously approved these changes Jun 23, 2025
ubieda
ubieda previously approved these changes Jun 23, 2025
Copy link
Member

@ubieda ubieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

MaureenHelm
MaureenHelm previously approved these changes Jun 23, 2025
bperseghetti
bperseghetti previously approved these changes Jun 23, 2025
kartben added 3 commits June 23, 2025 17:32
Update the dt snippet so that it includes all the required properties

Signed-off-by: Benjamin Cabé <[email protected]>
This was missed when the driver was contributed in 8f789f8

Signed-off-by: Benjamin Cabé <[email protected]>
This was missed when the driver was contributed in 2759ada

Signed-off-by: Benjamin Cabé <[email protected]>
This was missed when the driver was contributed in 756e699

Signed-off-by: Benjamin Cabé <[email protected]>
@kartben
Copy link
Contributor Author

kartben commented Jun 23, 2025

Rebased to fix merge conflicts in the i2c.dtsi file

Copy link

@kartben
Copy link
Contributor Author

kartben commented Jun 24, 2025

@MaureenHelm please refresh so that it doesn't go to rebase jail again :) Thanks!

@dkalowsk dkalowsk merged commit 8b8a51f into zephyrproject-rtos:main Jun 25, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants