-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Add support for ADC16 driver on RA2A1 MCU #95710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
18491ba to
3dabfb2
Compare
3dabfb2 to
5bfe2be
Compare
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
JarmouniA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the discussion in #94585, redundancy in test coverage of the same IP/driver need to be avoided.
5bfe2be to
0bcc6e0
Compare
04cff21 to
893e7ce
Compare
|
last push rebase and resolve conflict |
|
| &adc0 { | ||
| status = "okay"; | ||
| pinctrl-0 = <&adc0_default>; | ||
| pinctrl-names = "default"; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "scanend" interrupt is required to enable this node
| &adc0 { | |
| status = "okay"; | |
| pinctrl-0 = <&adc0_default>; | |
| pinctrl-names = "default"; | |
| }; | |
| &adc0 { | |
| pinctrl-0 = <&adc0_default>; | |
| pinctrl-names = "default"; | |
| interrupts = <13 3>; | |
| interrupt-names = "scanend"; | |
| status = "okay"; | |
| }; |
soburi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| #define DT_DRV_COMPAT renesas_ra_adc12 | ||
| DT_INST_FOREACH_STATUS_OKAY_VARGS(ADC_RA_INIT_VARIANT, ADC_VARIANT_ADC12, 12, ADC_RESOLUTION_12_BIT) | ||
| #undef DT_DRV_COMPAT | ||
|
|
||
| #define DT_DRV_COMPAT renesas_ra_adc16 | ||
| DT_INST_FOREACH_STATUS_OKAY_VARGS(ADC_RA_INIT_VARIANT, ADC_VARIANT_ADC16, 16, ADC_RESOLUTION_16_BIT) | ||
| #undef DT_DRV_COMPAT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's mostly a matter of preference, but using DT_FOREACH_STATUS_OKAY
may be easier to understand since it doesn't require #endif.
Like as
zephyr/drivers/display/ssd1306.c
Lines 575 to 577 in 5805685
| DT_FOREACH_STATUS_OKAY(solomon_ssd1306fb, SSD1306_DEFINE) | |
| DT_FOREACH_STATUS_OKAY(solomon_ssd1309fb, SSD1306_DEFINE) | |
| DT_FOREACH_STATUS_OKAY(sinowealth_sh1106, SSD1306_DEFINE) |
893e7ce to
c99792a
Compare
Adding ADC 16-bit driver compatible to support ADC16 on RA2A1 Signed-off-by: Thinh Le Cong <[email protected]>
Add ADC device node to support ADC 16-bit on EK-RA2A1 Update other Renesas board nodes to include the "unit" property Signed-off-by: Thinh Le Cong <[email protected]>
Add ADC device node on board layer to support ADC 16-bit on EK-RA2A1 Signed-off-by: Thinh Le Cong <[email protected]>
Add Renesas EK-RA2A1 board support for these tests: - tests/drivers/adc/adc_api - tests/drivers/adc/adc_accuracy_test Signed-off-by: Thinh Le Cong <[email protected]>
…oard Add Renesas EK-RA2A1 board support for sample: - samples/drivers/adc/adc_dt Signed-off-by: Thinh Le Cong <[email protected]>
Remove all doxygen comment blocks on driver Signed-off-by: Thinh Le Cong <[email protected]>
Update the migration guilde for ADC driver when support 16-bit resolution Signed-off-by: Thinh Le Cong <[email protected]>
c99792a to
bb88b52
Compare
|



This PR adding support for ADC16 driver on RA2A1 MCU