Skip to content

Conversation

@duynguyenxa
Copy link
Member

This PR adding support for ADC16 driver on RA2A1 MCU

@zephyrbot zephyrbot added area: Samples Samples area: ADC Analog-to-Digital Converter (ADC) platform: Renesas RA Renesas Electronics Corporation, RA labels Sep 9, 2025
@github-actions
Copy link

github-actions bot commented Sep 25, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Copy link
Contributor

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the discussion in #94585, redundancy in test coverage of the same IP/driver need to be avoided.

@duynguyenxa
Copy link
Member Author

last push rebase and resolve conflict

@github-actions github-actions bot removed manifest manifest-hal_renesas DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 20, 2025
@sonarqubecloud
Copy link

Comment on lines 123 to 131
&adc0 {
status = "okay";
pinctrl-0 = <&adc0_default>;
pinctrl-names = "default";
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "scanend" interrupt is required to enable this node

Suggested change
&adc0 {
status = "okay";
pinctrl-0 = <&adc0_default>;
pinctrl-names = "default";
};
&adc0 {
pinctrl-0 = <&adc0_default>;
pinctrl-names = "default";
interrupts = <13 3>;
interrupt-names = "scanend";
status = "okay";
};

@jhedberg jhedberg modified the milestones: v4.3.0, v4.4.0 Nov 11, 2025
@d3zd3z d3zd3z requested review from thenguyenyf and removed request for soburi and ydamigos November 11, 2025 15:23
Copy link
Member

@soburi soburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +462 to +468
#define DT_DRV_COMPAT renesas_ra_adc12
DT_INST_FOREACH_STATUS_OKAY_VARGS(ADC_RA_INIT_VARIANT, ADC_VARIANT_ADC12, 12, ADC_RESOLUTION_12_BIT)
#undef DT_DRV_COMPAT

#define DT_DRV_COMPAT renesas_ra_adc16
DT_INST_FOREACH_STATUS_OKAY_VARGS(ADC_RA_INIT_VARIANT, ADC_VARIANT_ADC16, 16, ADC_RESOLUTION_16_BIT)
#undef DT_DRV_COMPAT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mostly a matter of preference, but using DT_FOREACH_STATUS_OKAY
may be easier to understand since it doesn't require #endif.

Like as

DT_FOREACH_STATUS_OKAY(solomon_ssd1306fb, SSD1306_DEFINE)
DT_FOREACH_STATUS_OKAY(solomon_ssd1309fb, SSD1306_DEFINE)
DT_FOREACH_STATUS_OKAY(sinowealth_sh1106, SSD1306_DEFINE)

Thinh Le Cong added 7 commits November 19, 2025 06:55
Adding ADC 16-bit driver compatible to support ADC16 on RA2A1

Signed-off-by: Thinh Le Cong <[email protected]>
Add ADC device node to support ADC 16-bit on EK-RA2A1
Update other Renesas board nodes to include the "unit" property

Signed-off-by: Thinh Le Cong <[email protected]>
Add ADC device node on board layer to support ADC 16-bit on EK-RA2A1

Signed-off-by: Thinh Le Cong <[email protected]>
Add Renesas EK-RA2A1 board support for these tests:

- tests/drivers/adc/adc_api
- tests/drivers/adc/adc_accuracy_test

Signed-off-by: Thinh Le Cong <[email protected]>
…oard

Add Renesas EK-RA2A1 board support for sample:

- samples/drivers/adc/adc_dt

Signed-off-by: Thinh Le Cong <[email protected]>
Remove all doxygen comment blocks on driver

Signed-off-by: Thinh Le Cong <[email protected]>
Update the migration guilde for ADC driver when support
16-bit resolution

Signed-off-by: Thinh Le Cong <[email protected]>
@sonarqubecloud
Copy link

@jukkar jukkar removed their request for review November 24, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ADC Analog-to-Digital Converter (ADC) area: Boards/SoCs area: Devicetree Bindings area: Samples Samples area: Tests Issues related to a particular existing or missing test platform: Renesas RA Renesas Electronics Corporation, RA platform: Renesas Renesas Release Notes To be mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants