Skip to content

Conversation

tpambor
Copy link
Contributor

@tpambor tpambor commented Oct 9, 2025

Update hal_stm32 to include fix for compiling for STM32H5 with clang.

Fixes warning about extraneous parentheses when compiling with clang.

/home/user/west_workspace/modules/hal/stm32/stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_rcc_ex.c:3513:26: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
 3513 |         else if ((srcclk == RCC_USART2CLKSOURCE_PLL3Q))
      |                   ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/user/west_workspace/modules/hal/stm32/stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_rcc_ex.c:3513:26: note: remove extraneous parentheses around the comparison to silence this warning
 3513 |         else if ((srcclk == RCC_USART2CLKSOURCE_PLL3Q))
      |                  ~       ^                           ~
/home/user/west_workspace/modules/hal/stm32/stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_rcc_ex.c:3513:26: note: use '=' to turn this equality comparison into an assignment
 3513 |         else if ((srcclk == RCC_USART2CLKSOURCE_PLL3Q))
      |                          ^~
      |                          =

Copy link

github-actions bot commented Oct 9, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_stm32 zephyrproject-rtos/hal_stm32@ec75ca2 zephyrproject-rtos/hal_stm32@1889b71 (main) zephyrproject-rtos/[email protected]

Additional metadata changed:

Name URL Submodules West cmds module.yml Blobs
hal_stm32 8x ✏

DNM label due to: 1 project with metadata changes and 8 blob changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_stm32 DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 9, 2025
@zephyrbot zephyrbot added size: XS A PR changing only a single line of code platform: STM32 ST Micro STM32 labels Oct 9, 2025
@tpambor tpambor force-pushed the update-hal-stm32-clang branch from d021e22 to 7249c5b Compare October 11, 2025 17:51
Update hal_stm32 to include fix for compiling for STM32H5 with clang.

Signed-off-by: Tim Pambor <[email protected]>
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Binary Blobs Modified DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_stm32 platform: STM32 ST Micro STM32 size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants