Skip to content

drivers: comparator: add comparator support on Renesas RA LVD #97462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2025
Merged

drivers: comparator: add comparator support on Renesas RA LVD #97462

merged 5 commits into from
Oct 20, 2025

Conversation

@thenguyenyf
Copy link
Contributor

@thenguyenyf thenguyenyf commented Oct 13, 2025

Initial support for Renesas RA Comparator driver running on LVD HWIP

@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_renesas zephyrproject-rtos/hal_renesas@bbfc2e6 zephyrproject-rtos/hal_renesas@2a4f856 zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_renesas DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 13, 2025
bjarki-andreasen
bjarki-andreasen reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, could you extend the comparator build all and comparator api test suites to test the driver?

@thenguyenyf thenguyenyf force-pushed the renesas_ra_comparator_lvd branch from dc46844 to 012305a Compare October 14, 2025 03:14
@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label Oct 14, 2025
@zephyrbot zephyrbot requested a review from nashif October 14, 2025 03:37
@thenguyenyf
Copy link
Contributor Author

thenguyenyf commented Oct 14, 2025

Code looks good, could you extend the comparator build all and comparator api test suites to test the driver?

Hello @bjarki-andreasen . I added the configuration for comparator build all. For the comparator API test suite, it needs to add a new test, due to the LVD test need to control VCC changes, which will cause the existing GPIO loopback test cannot run.
The effort to add it may be too large to be done right now, so I'd like to move it after v4.3.0 merging close.

We tested the operation with the sample added at cab20ba. The samples configuration for this driver will be sent out soon by a subsequence PR after #93694 is merged.

bjarki-andreasen
bjarki-andreasen previously approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thenguyenyf
Copy link
Contributor Author

thenguyenyf commented Oct 15, 2025

Last push just to rebase and update west manifest revision due to it was merged

duynguyenxa
duynguyenxa previously approved these changes Oct 15, 2025
View reviewed changes
@thenguyenyf thenguyenyf added this to the v4.3.0 milestone Oct 15, 2025
@thenguyenyf
Copy link
Contributor Author

thenguyenyf commented Oct 15, 2025

Hello @KhiemNguyenT . Could you please visit and leave a review?

@thenguyenyf thenguyenyf force-pushed the renesas_ra_comparator_lvd branch from 7d56ef7 to cf350f1 Compare October 15, 2025 09:15
@thenguyenyf
Copy link
Contributor Author

thenguyenyf commented Oct 15, 2025

Last push just to rebase and solve conflict

duynguyenxa
duynguyenxa previously approved these changes Oct 17, 2025
View reviewed changes
Minh Tang and others added 5 commits October 17, 2025 09:57
@thenguyenyf
soc: renesas: ra: Support NMI Handler for RA8P1 SoC
d306b7f 
Add register NMI_Handler for NMI when CONFIG_RUNTIME_NMI is enabled on
RA8P1

Signed-off-by: Minh Tang <[email protected]>
@thenguyenyf
manifest: update rev of hal_renesas to latest
628464b 
Update hal_renesas revision to add r_lvd support

Signed-off-by: The Nguyen <[email protected]>
@thenguyenyf
drivers: comparator: Add comparator LVD driver support for RA
f17b998 
Add comparator support for RA with LVD module

Signed-off-by: Minh Tang <[email protected]>
@thenguyenyf
dts: renesas: ra: Add dts node for LVD support
289c213 
Add dts node for LVD support on RA8 MCUs

Signed-off-by: Minh Tang <[email protected]>
@thenguyenyf
tests: drivers: build_all: add renesas_lvd test configurations
c32c8f8 
Add build test configuration for renesas_lvd on Renesas RA boards
that currently support the comparator driver on LVD.

Signed-off-by: The Nguyen <[email protected]>
@thenguyenyf thenguyenyf force-pushed the renesas_ra_comparator_lvd branch from cf350f1 to c32c8f8 Compare October 17, 2025 10:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cfriedt cfriedt merged commit a463cc4 into zephyrproject-rtos:main Oct 20, 2025
28 checks passed
@thenguyenyf thenguyenyf deleted the renesas_ra_comparator_lvd branch October 20, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KhiemNguyenT KhiemNguyenT KhiemNguyenT approved these changes

@bjarki-andreasen bjarki-andreasen bjarki-andreasen approved these changes

@duynguyenxa duynguyenxa duynguyenxa approved these changes

@andrzej-kaczmarek andrzej-kaczmarek Awaiting requested review from andrzej-kaczmarek

@binhnguyen2434 binhnguyen2434 Awaiting requested review from binhnguyen2434

@blauret blauret Awaiting requested review from blauret

@ioannis-karachalios ioannis-karachalios Awaiting requested review from ioannis-karachalios

@khoa-nguyen-18 khoa-nguyen-18 Awaiting requested review from khoa-nguyen-18

@nhutnguyenkc nhutnguyenkc Awaiting requested review from nhutnguyenkc

@soburi soburi Awaiting requested review from soburi

@thaoluonguw thaoluonguw Awaiting requested review from thaoluonguw

@ydamigos ydamigos Awaiting requested review from ydamigos

@nashif nashif Awaiting requested review from nashif

@krish2718 krish2718 Awaiting requested review from krish2718

@sachinthegreen sachinthegreen Awaiting requested review from sachinthegreen

Assignees

@ioannis-karachalios ioannis-karachalios

@KhiemNguyenT KhiemNguyenT

Labels

area: Boards/SoCs area: Comparator area: Devicetree Bindings area: Tests Issues related to a particular existing or missing test manifest manifest-hal_renesas platform: Renesas RA Renesas Electronics Corporation, RA platform: Renesas Renesas

Projects

None yet

Milestone

v4.3.0

Development

Successfully merging this pull request may close these issues.

7 participants

@thenguyenyf @KhiemNguyenT @bjarki-andreasen @duynguyenxa @cfriedt @ioannis-karachalios @zephyrbot