drivers: comparator: Silence GCC 14 uninitialized variable warning. #98602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
size: XS
zephyrbot
requested review from
KhiemNguyenT,
bjarki-andreasen,
duynguyenxa,
khoa-nguyen-18,
soburi,
thaoluonguw and
thenguyenyf
carlescufi
approved these changes
Oct 30, 2025
JarmouniA
approved these changes
Oct 30, 2025
soburi
reviewed
Oct 31, 2025
Member
soburi
left a comment
soburi
left a comment
There was a problem hiding this comment.
Message prefix is shuold better as drivers: comparator: .
thenguyenyf
approved these changes
Oct 31, 2025
When the renesas-rv-lvd driver is built with SDK 1.0 using GCC 14, the compiler emits a spurious uninitialized variable warning because it can't follow the control flow to figure out that the variable wasn't ever used without being initialized. Work around this by simply initializing it to one of the valid values. Signed-off-by: Keith Packard <[email protected]>
keith-packard
force-pushed
the
comparator-gcc-14
branch
from
c3e9071 to
93c4109
Compare
keith-packard
changed the title
bjarki-andreasen
approved these changes
Oct 31, 2025
|
nashif
approved these changes
Oct 31, 2025
soburi
approved these changes
Nov 2, 2025
Member
|
@keith-packard - can you please link a bug report to this PR? It's required past RC2 |
Contributor
Author
It only fails with SDK 1.0, not SDK 0.17, so I'm not sure this should be considered for 4.3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the renesas-rv-lvd driver is built with SDK 1.0 using GCC 14, the compiler emits a spurious uninitialized variable warning because it can't follow the control flow to figure out that the variable wasn't ever used without being initialized. Work around this by simply initializing it to one of the valid values.