Bluetooth: hci_nxp: Fix Unique ID offset when setting MAC address #98623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bt_nxp_set_mac_address function incorrectly calculates the offset when attempting to extract the last 3 bytes of the MCU Unique ID (UID) to form the local part of the Bluetooth MAC address. The incorrect offset calculation included an extra '- 1', causing the copy operation to miss the final byte of the UID and copy a less unique or non-intended byte sequence. Fix this by correcting the offset calculation to: 'uid + uuidLen - BD_ADDR_UUID_PART_SIZE'. Signed-off-by: Badr Bacem KAABIA <[email protected]>
zephyrbot
added
area: Bluetooth
size: XS
zephyrbot
requested review from
George-Stefan,
HaavardRei,
HoZHel,
MaochenWang1,
PavelVPV,
Thalley,
alwa-nordic,
axelnxp,
cvinayak,
dleach02,
hermabe,
jhedberg and
sjanc
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch corrects a logical error in the
bt_nxp_set_mac_addressfunctionwhere a dynamically generated Bluetooth MAC address uses the device's
Unique ID (UID) for its local part (3 LSBs).
Problem:
The offset calculation used in
memcpywas:uid + uuidLen - (BD_ADDR_UUID_PART_SIZE + 1)This resulted in missing the last byte of the actual UID data, potentially
leading to non-unique or less-random MAC addresses when the UID is
longer than 3 bytes.
Fix:
The offset is corrected to use only the size of the MAC part:
uid + uuidLen - BD_ADDR_UUID_PART_SIZEThis ensures the last
BD_ADDR_UUID_PART_SIZE(3) bytes of the MCUUID are used as intended.