Skip to content

Conversation

@himanshuseth-microchip
Copy link

This pull request adds Ethernet and MDIO driver support for the Microchip GMAC peripheral. It introduces the Ethernet and MDIO driver implementation and updates the devicetree for the SAM D5x/E5x series to include the required node and bindings.

Added Support for Ethernet Driver.

Signed-off-by: Himanshu Seth <[email protected]>
Added File related to EEPROM feature for Ethernet driver.

Signed-off-by: Himanshu Seth <[email protected]>
Added Support for MDIO Driver.

Signed-off-by: Himanshu Seth <[email protected]>
Incorporated review comments with respect to clock usage in mdio and
ethernet driver code.

Signed-off-by: Himanshu Seth <[email protected]>
Incorporated review comments on MDIO and Ethernet Driver

Signed-off-by: Himanshu Seth <[email protected]>
Moved Rx packet handling from ISR to Worker Thread in Ethernet Driver

Signed-off-by: Himanshu Seth <[email protected]>
…iver.

Incorporated more review comments on MDIO and Ethernet Driver.

Signed-off-by: Himanshu Seth <[email protected]>
Changed function names for MDIO and Ethernet Driver.

Signed-off-by: Himanshu Seth <[email protected]>
    Add the device tree node and the binding file for
    microchip eth G1 Peripheral.

    Signed-off-by: Himanshu Seth <[email protected]>
    Add Eth driver for Microchip eth G1 Peripherals.

    Signed-off-by: Himanshu Seth <[email protected]>
    Add required DTS changes to enable Eth on sam_e54_xpro.

    Signed-off-by: Himanshu Seth <[email protected]>
    Add the device tree node and the binding file for
    microchip mdio G1 Peripheral.

    Signed-off-by: Himanshu Seth <[email protected]>
    Add mdio driver for Microchip mdio G1 Peripherals.

    Signed-off-by: Himanshu Seth <[email protected]>
…build

Fixed the compilation issue with the latest build for eth Driver.

Signed-off-by: Himanshu Seth <[email protected]>
Removed do while(0) for Microchip mdio G1 Peripherals.

Signed-off-by: Himanshu Seth <[email protected]>
…eripherals

Removed dependecy of i2c driver for eth G1 Peripherals.

Signed-off-by: Himanshu Seth <[email protected]>
@github-actions
Copy link

Hello @himanshuseth-microchip, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@sonarqubecloud
Copy link

Copy link
Member

@maass-hamburg maass-hamburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks very similar to eth_sam_gmac.c, wasn't it possible to integrate that

Comment on lines +82 to +107
config ETH_MCHP_MAC_I2C_EEPROM
default y
select I2C
bool "Read from an I2C EEPROM"
help
Read MAC address from an I2C EEPROM.

if ETH_MCHP_MAC_I2C_EEPROM

config ETH_MCHP_MAC_I2C_INT_ADDRESS
hex "I2C EEPROM internal address"
default 0x9A
range 0 0xffffffff
help
Internal address of the EEPROM chip where the MAC address is stored.
Chips with 1 to 4 byte internal address size are supported. Address
size has to be configured in a separate Kconfig option.

config ETH_MCHP_MAC_I2C_INT_ADDRESS_SIZE
int "I2C EEPROM internal address size"
default 1
range 1 4
help
Size (in bytes) of the internal EEPROM address.

endif # ETH_MCHP_MAC_I2C_EEPROM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, see #91040 (comment) for more infos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants