This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Bug fixes amongst other improvements (huge PR) #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the following: - Naming all .format() variables - Add BotAdmin.clear command - Fix errors with variable names - Update "ignore" and "disable" command error messages - Add UTF-8 declaration to all files
|
This is very hard to go through and actually see what you changes since a large number of the changes are just you switching from spaces to tabs. I don't really know why you're doing that anyways. I'll try to sort through what I can soon. |
|
Aw shoot, my bad for the indent changes (I prefer tabs, as you can probably tell), apparently my Git client's "Ignore whitespace changes" doesn't actually work. >~< Changed it back to spaces so it's easier to go through! |
de-odex
reviewed
Apr 23, 2018
de-odex
reviewed
Apr 23, 2018
de-odex
reviewed
Apr 23, 2018
There was a problem hiding this comment.
I think the logging module would be preferred here
referring to https://github.com/rauenzi/discordbot.py/pull/5/files#diff-c716f17f1fe5f8eb9dfbffa44ca9eb33R132
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on my own Twyt Discord bot, there were a number of little fixes and updates I had performed. These updates include the following: