This repository was archived by the owner on Jun 26, 2020. It is now read-only.
fix premade embed colors and failure() title #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerebos
reviewed
Apr 24, 2018
| @@ -38,7 +38,7 @@ def __init__(self, bot : discordbot): | |||
| color = params.pop("color", Colors.get_default(self.bot)) | |||
| if isinstance(color, Colors): color = color.value | |||
| e = embeds.build_embed(title=params.pop("title", ""), description=params.pop("message", params.pop("description", "")), | |||
| color=params.pop("color", Colors.get_default(self.bot)), **params) | |||
| color=color, **params) | |||
There was a problem hiding this comment.
Why do this? The original will grab the color parameter passed, and if not passed use the default color. Yours will grab the color, and if it doesn't exist it can cause error or use discord's default as opposed to bot's default.
There was a problem hiding this comment.
doesnt pop remove the element from the list? you already did it once at the top, doing it again will always return Colors.get_default(self.bot)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.