Fix getEffectiveProjectId to prioritize passed projectId over GITLAB_PROJECT_ID#320
Draft
Fix getEffectiveProjectId to prioritize passed projectId over GITLAB_PROJECT_ID#320
Conversation
…PROJECT_ID - Changed the function to return projectId first if provided, then GITLAB_PROJECT_ID - Added proper error handling when neither projectId nor GITLAB_PROJECT_ID is available - Added comprehensive test suite to validate the fix Co-authored-by: zereight <42544600+zereight@users.noreply.github.com>
Co-authored-by: zereight <42544600+zereight@users.noreply.github.com>
…checks Co-authored-by: zereight <42544600+zereight@users.noreply.github.com>
Co-authored-by: zereight <42544600+zereight@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix getEffectiveProjectId to return specified projectId
Fix getEffectiveProjectId to prioritize passed projectId over GITLAB_PROJECT_ID
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
GITLAB_ALLOWED_PROJECT_IDSis unset,getEffectiveProjectIdwas returningGITLAB_PROJECT_IDeven when a differentprojectIdwas explicitly passed, preventing users from querying other projects via tools likeget_project.Changes
projectIdparameter beforeGITLAB_PROJECT_IDenvironment variableBefore
After
This allows
get_projectand similar tools to accept any project ID/path when no allowlist is configured, while maintaining backward compatibility whenprojectIdis omitted.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.