Add ECDSAExecutor module #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments - Implement 2D-nonce system compatible with EntryPoint v0.7 - Add signature expiration time validation - Add zero address validation in onInstall - Emit OwnerUnregistered event on uninstall - Add proper error types (InvalidSignature, InvalidOwner) - Restrict incrementNonce to initialized accounts only - Achieve 100% test coverage with comprehensive edge case tests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Use abi.decode instead of direct byte casting for owner extraction - Add _isInitialized check in onInstall to prevent re-initialization - Change nonceSequenceNumber mapping from uint256 to uint64 for consistency - Implement EIP-712 using Solady's EIP712 library for better gas efficiency - Remove support for EIP-191 signatures, only EIP-712 now supported - Keep packed nonce approach for gas efficiency - Keep incrementNonce method for security (allows invalidating nonce sequences) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Co-authored-by: Sammy <[email protected]>
Co-authored-by: Sammy <[email protected]>
ECDSAExecutor module
|
sound interesting, few questions
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces the ECDSAExecutor module, an ERC-7579 executor that enables off-chain transaction authorization for smart accounts using ECDSA signatures.
Key Features
Changes
Security Highlights
Test Coverage
Full test suite included covering: