Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goctl): allow duplicate_path_expression under different prefix #4626

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

youzipi
Copy link
Contributor

@youzipi youzipi commented Feb 6, 2025

question

after upgrade to [email protected],
goctl api go with throw duplicate_path_expression err when there are two same path under different prefix.

solution

fix the ast keyword when building path unique id.

@youzipi
Copy link
Contributor Author

youzipi commented Feb 6, 2025

after run gofmt -s -w ./tools/goctl/pkg/parser/api/parser, lots of lines are changed.
do i need extra parameters ?

@kevwan kevwan requested a review from kesonan February 6, 2025 16:05
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.56%. Comparing base (8690859) to head (7f0bffa).
Report is 254 commits behind head on master.

Additional details and impacted files

see 8 files with indirect coverage changes

Copy link
Collaborator

@kesonan kesonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevwan kevwan added this pull request to the merge queue Feb 7, 2025
Merged via the queue into zeromicro:master with commit e347d3f Feb 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants