fix: fix the bug of the numeric/decimal data type in pg #4686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4624.
I tried the PostgreSQL DDL and use both numeric and decimal type to generate the model.
balance_test_tab.sql
Output
These cases both gave the int64 type to the code.
Otherwise, I use DDL in MySQL below:
Output
The type was float64.
Key Reason
When goctl use datasource to get the columns info, it will transfer the type to mysql type. The
numeric/decimal
was transfer to the bigint type, and it was not reasonable.tools/goctl/model/sql/model/postgresqlmodel.go