bump ksm - #290
Open
osleg wants to merge 8 commits into
Open
Conversation
osleg
requested review from
Awish021,
BorisRodman,
IdoKendo,
Tomerfi1210,
ilanovadia,
michaelamar1991 and
omerxx
as code owners
June 1, 2026 14:42
ilanovadia
requested changes
Jun 9, 2026
| exit 1 | ||
| fi | ||
| echo "⚠️ kubeStateMetrics.enabled is set to false — kubeStateMetrics will not be installed, going to use the existing service: $KSM_SVC_NAME" | ||
| if [ "$KSM_SCRAPE_MODE" = "perResource" ]; then |
Contributor
There was a problem hiding this comment.
Wwe need this warning only when "$KSM_SCRAPE_MODE" = "perResource" and the user work with an external ksm and not ours
Author
There was a problem hiding this comment.
I think we either have a general problem with this block or I misunderstand something
Contributor
There was a problem hiding this comment.
When we install our own KSM, all is good since we control the version -> per resource is supported.
When we do not install our KSM, we can't tell what version the customer uses, so if it is configured per resource, we should raise this warning.
Author
There was a problem hiding this comment.
yeah that's how it is, we only print this if the KSM is not owned by us and if scrape mod is set to per resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.