Added missing OpenGL 4.0-4.6 functions to wrapper #30
+7,359
−1,969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added missing `glVertexAttribLPointer` and `glGetVertexAttribLdv` (OpenGL 4.1) to bindings, * implemented wrapper functions `clearDepthf` and `depthRangef` in OpenGL ES 1.0 section, * added missing fields to various already defined enums, * moved various inline definitions of parameter types to the section where types and enums are defined, * defined `DrawArraysIndirectCommand` and `DrawElementsIndirectCommand`, since definitions of them in bindings will likely be removed, * made `DEBUGPROC` a function type instead of it being a function pointer (makes arguments more readable).
There was a problem hiding this comment.
Pull request overview
This PR adds missing OpenGL 4.0-4.6 function bindings to the wrapper library, with a focus on completing the OpenGL 4.1 support. The main changes include adding two missing vertex attribute functions and refactoring the DEBUGPROC type definition to be more idiomatic.
- Added missing
glVertexAttribLPointerandglGetVertexAttribLdvfunctions from OpenGL 4.1 - Refactored
DEBUGPROCfrom a function pointer type to a function type, with corresponding usage updates
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/zopengl.zig | Added loader calls for the two new OpenGL 4.1 vertex attribute functions |
| src/bindings.zig | Defined function signatures for vertexAttribLPointer and getVertexAttribLdv, and refactored DEBUGPROC type definition with updated usages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other notable changes:
glVertexAttribLPointerandglGetVertexAttribLdv(OpenGL 4.1) to bindings,clearDepthfanddepthRangefin OpenGL ES 1.0 section,DrawArraysIndirectCommandandDrawElementsIndirectCommand, since definitions of them in bindings will likely be removed,DEBUGPROCa function type instead of it being a function pointer (makes arguments more readable).